Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined fpoptions prevents Marklar from loading #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juancs
Copy link
Contributor

@juancs juancs commented Dec 26, 2019

I've been facing a problem where, sometimes, Marklar doesn't loads in the page.

The init function int the amd module uses M.editor_marklar.
js_init_code is put in the page after the init call leading to a race condition: sometimes M.editor_marklar is defined, sometimes it isn't.

With this patch, M.editor_marklar is initialized just before the init function gets called.

@mudrd8mz
Copy link
Owner

mudrd8mz commented Jun 9, 2021

Well spotted @juancs - and thanks for the patch! I'll try to reproduce this and debug a bit more. Maybe this is a good opportunity to actually modernise the whole JS loading to match the latest moodledev guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants