Rename to codeowners, extend configuration capabilities, add pre-commit-hook support #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a few issues at once which I found while getting to know the project. In order to allow the use of
codeowners-validator
as pre-commit hook a lot of changes were necessary. As described in #140 pre-commit hooks do not really work with env variables and flags are currently not supported by the code base. Additionally in #116 it was considered to renamecodeowners-validator
tocodeowners
in order to make the project more future proof for further functions.Changes proposed in this pull request:
codeowners-validator
tocodeowners
and create avalidate
subcommand which inhibits the current capabilities of this projectCODEOWNERS_
.api
andconfig
into own packagesRelated issue(s)
Additional information
I fixed most of the integration tests but can't run the ones which require an API key. The other tests run fine.
One issue I wasn't able to fix is in the commit c372b63. I have no idea how to add a custom type as flag since I need to convert it somewhere. I would appreciate help there :) Other than that it's very possible I made some errors or mistakes which could be solved more elegantly. Feedback is very welcome!
This PR also includes #197.