fix: do not treat static asset requests as unhandled by default #2440
+156
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, MSW catches all requests that go through the Service Worker. This includes all the static assets too, like CSS or HTML or fonts. Treating them as unhandled rarely makes sense.
Changes
isCommonAssetRequest
utility function frommsw
.onUnhandledRequest
to exclude common static assets before applying string behaviors like'warn'
.onUnhandledRequest
. If you do, then you have to import and useisCommonAssetRequest()
manually to get the default behavior back. This is intended for behavior customization.