Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update column picker #5907

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Update column picker #5907

merged 2 commits into from
Jan 3, 2025

Conversation

mark-prins
Copy link
Collaborator

Fixes #5396
There's been some chatter on this one, so I thought to tidy it up. This builds on the work of myspace20 πŸ™ and implements the changes discussed after.

πŸ‘©πŸ»β€πŸ’» What does this PR do?

  • Hides the selection column in the column picker
  • Adds a 'Show all' button which is enabled if some columns are hidden
  • Renames the selection column to be Select / unselect all rows
  • Hides the selection column if all columns are hidden
Screenshot 2024-12-31 at 1 02 32β€―PM Screenshot 2024-12-31 at 1 02 12β€―PM

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

  • The selection column isn't shown in the column picker
  • the tooltip of the selection column says 'rows' not 'columns'
  • hiding all columns also hides the selection column
  • a 'Show all' button is shown in the picker
  • and is disabled if all columns are shown
  • and enables all columns if clicked

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1. Need to update screenshots and column picker deets

@github-actions github-actions bot added this to the v2.5.0 milestone Dec 31, 2024
@github-actions github-actions bot added bug Something is borken good first issue Good for newcomers Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. labels Dec 31, 2024
@mark-prins mark-prins mentioned this pull request Dec 31, 2024
8 tasks
Copy link

github-actions bot commented Dec 31, 2024

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.02 MB 5.02 MB 563 B (0.01%)

@mark-prins
Copy link
Collaborator Author

Side quest: fixed the date test

Copy link
Contributor

@roxy-dao roxy-dao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks Mark :D

@roxy-dao roxy-dao self-assigned this Jan 2, 2025
@mark-prins mark-prins merged commit 6bbef8d into develop Jan 3, 2025
4 checks passed
@mark-prins mark-prins deleted the 5396-hide-show-hide branch January 3, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken good first issue Good for newcomers Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show hide all columns doesn't
2 participants