-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow editing of asset number #5651
Conversation
Follow-up: #5652 |
Bundle size differenceComparing this PR to
|
It would be nice, but not sure how we would do it if assets can be added offline? |
We an asset number duplication check in the
Can you add this to the I agree @adamdewey we can't guarentee it doesn't get duplicated with sync but would be good to keep it unique for a site at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but can you add that duplication check, or put a follow up issue for that to be picked up refactor week?
On second thoughts I think we'll need to make it check that it's not the same id that the current asset is using. |
Fixes #5392
π©π»βπ» What does this PR do?
This is the simplest version of this -- it just makes the Asset number editable after the asset is created. I'll make a follow-up issue to get user input on scanning, as that's a bit more involved and could do with some further planning to make it work nicely.
π Any notes for the reviewer?
I notice we're not enforcing unique-ness for Asset number. Should it be?
π§ͺ Testing