Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to enter an asset number when creating an asset via 2d Matrix Barcode Scan #5392

Open
jmbrunskill opened this issue Nov 12, 2024 · 6 comments · May be fixed by #5651
Open

Allow user to enter an asset number when creating an asset via 2d Matrix Barcode Scan #5392

jmbrunskill opened this issue Nov 12, 2024 · 6 comments · May be fixed by #5651
Assignees
@CarlosNZ
Labels
enhancement New feature or request feature: CCEI feature: GAPS Priority: Must Have The product will not work without this Team Piwakawaka James, Laché, Carl
Milestone
v2.4.1

Comments

@jmbrunskill
Copy link
Contributor

jmbrunskill commented Nov 12, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe 👀

When importing a cold chain equipment asset via a 2d Data Matrix, the user doesn't get an opportunity to enter an asset number (serial number is used instead)

Describe the solution you'd like 🎁

User should get a prompt to enter an asset number when confirming they want to create the asset.

Describe alternatives you've considered 💭

Could allow asset number editing? Might be a better solution?

Should also consider consolidating the saving logic between the new asset modal and the scan button.
Potentially logic such as adding the first functional status on creation should be moved to the backend???

Additional context 💌

Moneyworks Jobcode 🧰
@jmbrunskill jmbrunskill mentioned this issue Nov 12, 2024
Merged
13 tasks
@adamdewey
Copy link
Contributor

It would be good to allow users to edit the asset number, especially as we don't perform any checks for duplicate asset numbers across the country system currently.

@jmbrunskill
Copy link
Contributor Author

Should also clean up Ref usage in the confirmation modal https://github.com/msupply-foundation/open-msupply/pull/5382/files/76d409d3e4673c2ec7a0f29aa191164aa063891d#r1839293136

@lache-melvin
Copy link
Contributor

Further request for asset number to be editable: #5469

@lache-melvin lache-melvin mentioned this issue Nov 19, 2024
Closed
@andreievg andreievg added Priority: Must Have The product will not work without this and removed needs triage labels Nov 20, 2024
@andreievg andreievg added this to the V2.4.0-RC3 milestone Nov 20, 2024
@lache-melvin lache-melvin added the Team Piwakawaka James, Laché, Carl label Nov 21, 2024
@jmbrunskill jmbrunskill modified the milestone: V2.4.0-RC5 Nov 27, 2024
@CarlosNZ
Copy link
Contributor

Clarifying -- are we doing:

  • making asset number editable in Asset detail view
  • allowing asset number input on scan
  • both?

And if the first one, assume we'd just put the number in the main form and make it a field along with everything else?

@adamdewey
Copy link
Contributor

adamdewey commented Nov 27, 2024 •
edited
Loading

Clarifying -- are we doing:

  • making asset number editable in Asset detail view
  • allowing asset number input on scan
  • both?

For CCE, I can see HCW getting confused if they don't know what the asset number should be, so for scanning I think we should default the asset number to the serial number but allow it to editable?

And if the first one, assume we'd just put the number in the main form and make it a field along with everything else?

Sounds good to me..

@jmbrunskill jmbrunskill modified the milestones: V2.4.0-RC7, v2.4.1 Nov 28, 2024
@jmbrunskill
Copy link
Contributor Author

Moved to 2.4.1 as @CarlosNZ is still in progress with this, and 2.4.1 is releasing soon enough...

@CarlosNZ CarlosNZ linked a pull request Nov 29, 2024 that will close this issue
Open
3 tasks
@CarlosNZ CarlosNZ linked a pull request Nov 29, 2024 that will close this issue
Allow editing of asset number #5651
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarlosNZ CarlosNZ

Labels
enhancement New feature or request feature: CCEI feature: GAPS Priority: Must Have The product will not work without this Team Piwakawaka James, Laché, Carl
Projects
None yet
Milestone
v2.4.1
Development

Successfully merging a pull request may close this issue.

Allow editing of asset number msupply-foundation/open-msupply
6 participants
@CarlosNZ @jmbrunskill @adamdewey @andreievg @lache-melvin @roxy-dao