Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show hide all columns doesn't #5396

Closed
mark-prins opened this issue Nov 13, 2024 · 3 comments · Fixed by #5907
Closed

Show hide all columns doesn't #5396

mark-prins opened this issue Nov 13, 2024 · 3 comments · Fixed by #5907
Labels
bug Something is borken Build Tested: Passed Issue has been build tested with all tests passed. good first issue Good for newcomers Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. Tester: Maria
Milestone

Comments

@mark-prins
Copy link
Collaborator

What went wrong? 😲

I experienced some confusion - and expect that others may have the same problem..

When showing and hiding columns, there is a very useful option to show/hide all columns. That's what I wanted to do, so I clicked it, and was disappointed with the result:

Screen.Recording.2024-11-13.at.3.04.44.PM.mp4

Expected behaviour 🤔

The column was the show/hide checkbox column and I was showing and hiding that - and not all the columns which were available.

If there was a 'select all' checkbox at the top of the column visibility popup then I wouldn't be so confused. Renaming the rogue column would also help, but might introduce other confusion!

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Go to the detail view of an outbound shipment, say (any table with column selection will do)
  2. Click the show/hide column button

Your environment 🌱

  • Open mSupply Version:
  • Legacy mSupply Central Server Version:
  • Platform:
  • Database type:
@mark-prins mark-prins added bug Something is borken needs triage needs daily triage New bug to be triaged by the release team labels Nov 13, 2024
@andreievg andreievg added good first issue Good for newcomers Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. and removed needs daily triage New bug to be triaged by the release team labels Nov 15, 2024
@myspace20 myspace20 mentioned this issue Nov 19, 2024
8 tasks
@roxy-dao roxy-dao added this to the v2.5.0 milestone Nov 20, 2024
@CarlosNZ
Copy link
Contributor

@mark-prins -- there is some confusion here caused by the labelling of this: it should actually be "Select / unselect all rows", as this is what the column header does on the actual table.

Also, it doesn't actually make any sense to be able to toggle all columns off.

I've added my suggested functionality to the PR for this: #5475 (review)

Perhaps we should get some further clarification/agreement about what the correct design should be before doing further work on this?

@mark-prins
Copy link
Collaborator Author

as noted on the PR - the use case for toggling them all off is if I have a lot of columns and just want to display a few. I can toggle all off with one click and show the wanted columns with a few clicks. The alternative is a lot of clicking 'hide'

The first two requirements you've got in the PR would fix my immediate problem:

  • name the checkbox column correctly
  • don't show that as an option in the column picker

after that I'm not fussed either way: having a show/hide all or a restore option. would be fine to just do the first two bits and close the issue tbh

@mark-prins mark-prins mentioned this issue Dec 31, 2024
9 tasks
@marthakeezy marthakeezy added Build Tested: Passed Issue has been build tested with all tests passed. Tester: Maria labels Jan 15, 2025
@marthakeezy
Copy link

marthakeezy commented Jan 15, 2025

Tested in V2.5.0-RC3, now there is only one option to show all columns, and hiding is done by manually unticking each one. Build test passed, moving to Done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken Build Tested: Passed Issue has been build tested with all tests passed. good first issue Good for newcomers Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. Tester: Maria
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants