arm64: dts: qcom: xiaomi-prada: fix keycodes#16
Closed
NekoCWD wants to merge 3 commits intomsm89x7-mainline:msm89x7/6.13.6from
Closed
arm64: dts: qcom: xiaomi-prada: fix keycodes#16NekoCWD wants to merge 3 commits intomsm89x7-mainline:msm89x7/6.13.6from
NekoCWD wants to merge 3 commits intomsm89x7-mainline:msm89x7/6.13.6from
Conversation
Enable ov5670 and flash for Redmi 3S.
Signed-off-by: Vasiliy Doylov <nekodevelopper@gmail.com>
Signed-off-by: Vasiliy Doylov <nekodevelopper@gmail.com>
Collaborator
|
arm64: dts: qcom: xiaomi-prada: fix keycodes -> this can be a simple fix up commit |
barni2000
requested changes
Mar 11, 2025
| &cci { | ||
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&cci1_default>, | ||
| <&cci0_default>, |
Collaborator
There was a problem hiding this comment.
Suggested change
| <&cci0_default>, |
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&cci1_default>, | ||
| <&cci0_default>, | ||
| <&camss_mclk2_default>; |
Collaborator
There was a problem hiding this comment.
Maybe it should be moved to the camera pinctrl
| &camss { | ||
| compatible = "qcom,msm8917-camss"; | ||
| status = "okay"; | ||
| vdda-supply = <&pm8937_s3>; |
Collaborator
There was a problem hiding this comment.
Suggested change
| vdda-supply = <&pm8937_s3>; | |
| vdda-supply = <&pm8937_l2>; |
barni2000
requested changes
Mar 11, 2025
| drive-strength = <2>; | ||
| }; | ||
|
|
||
| camss_mclk0_default: camss-mclk0-default-state { |
Collaborator
There was a problem hiding this comment.
Use mclk pinctrls from msm8937.dtsi
barni2000
force-pushed
the
msm89x7/6.13.6
branch
2 times, most recently
from
91942fd to
88a5d15
Compare
Collaborator
|
Thank You! I have fixed your commits and applied them. |
Author
|
Thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasiliy Doylov nekodevelopper@gmail.com