Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm64: dts: qcom: pmi8950: enable vibrator haptics #121

Draft
wants to merge 5 commits into
base: 6.4.7/main
Choose a base branch
from
Draft

arm64: dts: qcom: pmi8950: enable vibrator haptics #121

wants to merge 5 commits into from

Conversation

M0Rf30
Copy link

@M0Rf30 M0Rf30 commented Aug 6, 2023 •
edited
Loading

from dmesg:

[   14.312943] input: spmi_haptics as /devices/platform/soc@0/200f000.spmi/spmi-0/0-03/200f000.spmi:pmic@3:haptics@c000/input/input4

with fftest

xiaomi-vince:~$ sudo fftest /dev/input/event4
Force feedback test program.
HOLD FIRMLY YOUR WHEEL OR JOYSTICK TO PREVENT DAMAGES

Device /dev/input/event4 opened
Features:
  * Absolute axes:
    [00 00 00 00 00 00 00 00 ]
  * Relative axes:
    [00 00 ]
  * Force feedback effects types: Periodic, Rumble, Gain,
    Force feedback periodic effects: Square, Triangle, Sine,
    [00 00 00 00 00 00 00 00 00 00 03 07 01 00 00 00 ]
  * Number of simultaneous effects: 16

Setting master gain to 75% ... OK
Uploading effect #0 (Periodic sinusoidal) ... OK (id 0)
Uploading effect #1 (Constant) ... Error: Invalid argument
Uploading effect #2 (Spring) ... Error: Invalid argument
Uploading effect #3 (Damper) ... Error: Invalid argument
Uploading effect #4 (Strong rumble, with heavy motor) ... OK (id 1)
Uploading effect #5 (Weak rumble, with light motor) ... OK (id 2)

calebccff and others added 5 commits August 6, 2023 12:25
@calebccff @M0Rf30
dt-bindings: input: add Qualcomm SPMI haptics driver
f2705df 
Add bindings for qcom PMIC SPMI haptics driver.

Signed-off-by: Caleb Connolly <[email protected]>
@calebccff @M0Rf30
input: add Qualcomm SPMI haptics driver
632eed3 
Add support for the haptics found in pmi8998 and related PMICs.
Based on the ff-memless interface. Currently this driver provides
a partial implementation of hardware features.

This driver only supports LRAs (Linear Resonant Actuators) in the "buffer"
mode with a single wave pattern.

Signed-off-by: Caleb Connolly <[email protected]>
@M0Rf30
dt-bindings: input: add pmi8950-haptics identifier
249231d 
Signed-off-by: Gianluca Boiano <[email protected]>
@M0Rf30
arm64: dts: qcom: pmi8950: add pmi8950-haptics
821e131 
Signed-off-by: Gianluca Boiano <[email protected]>
@M0Rf30
arm64: dts: qcom: msm8953: xiaomi-vince: enable haptics
8539ebf 
Signed-off-by: Gianluca Boiano <[email protected]>
@M0Rf30 M0Rf30 marked this pull request as draft August 6, 2023 11:51
@barni2000
Copy link
Member

Some times i got this.

[   75.587484] spmi-haptics 200f000.spmi:pmic@3:haptics@c000: Short circuit persists, disabling haptics
[  134.782851] spmi-haptics 200f000.spmi:pmic@3:haptics@c000: Short circuit persists, disabling haptics
[  136.148232] spmi-haptics 200f000.spmi:pmic@3:haptics@c000: Short circuit persists, disabling haptics

spongy-deluxe
spongy-deluxe reviewed May 23, 2024
View reviewed changes
arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts
&pmi8950_haptics {
status = "okay";

qcom,wave-play-rage-us = <5263>;
Copy link

@spongy-deluxe spongy-deluxe May 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how relevant this PR still is but since it is not closed:

This line contains a bit too much rage instead of rate. ;)
It should probably be qcom,wave-play-rate-us.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is still relevant thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barni2000 barni2000 barni2000 left review comments

@spongy-deluxe spongy-deluxe spongy-deluxe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@M0Rf30 @barni2000 @spongy-deluxe @calebccff