[DNM] dts: msm8994: Add support for LG Nexus 5X (Bullhead) #504
Conversation
Dominduchami
changed the title
|
Just found out that 5X accepts the lg g4 dtb for some reason, will need to investigate further, changing the pr name for now until this is resolved |
| #include <lk2nd.dtsi> | ||
|
|
||
| / { | ||
| qcom,msm-id = <QCOM_ID_MSM8992 0>, <QCOM_ID_APQ8092 0>; |
There was a problem hiding this comment.
Nah it's msm8992 with internal modem.
The bootloader seems to favor LG G4 dts over it's own one tho.
That happens cause LG build the Nexus 5X and it reuses their G4's LK.
Doesn't lk2nd have like that match thingy we can set to match to bullheads cmdline ?
There was a problem hiding this comment.
Ah, I see, this and lg-h815 both use 2916 dtb, just that one is written as hex... Then you need to combine them into a single file and introduce matching rules for both devices, yes. So bullhead and h815 will share a file.
But here I was asking which of two msm-id are correct: MSM8992 (LTE) or APQ8092 (WiFI only soc)?
There was a problem hiding this comment.
Ah, I see, this and lg-h815 both use 2916 dtb, just that one is written as hex... Then you need to combine them into a single file and introduce matching rules for both devices, yes. So bullhead and h815 will share a file.
Is there an example of that being done before?
But here I was asking which of two msm-id are correct: MSM8992 (LTE) or APQ8092 (WiFI only soc)?
Should be msm8992, although the stock dtb seems to specify both?
There was a problem hiding this comment.
Is there an example of that being done before?
many many other dts files in other platforms are combined, can see samsung as the most blatant offender :)
Should be msm8992
if it works with just MSM, then let's drop the other one. downstream dtsi usually just defines all of them and OEMs never fix it.
No description provided.