arm64: dts: qcom: msm8916-fy-mf800: Add initial device tree#410
Open
reey wants to merge 1 commit intomsm8916-mainline:msm8916/6.12.1from
Open
arm64: dts: qcom: msm8916-fy-mf800: Add initial device tree#410reey wants to merge 1 commit intomsm8916-mainline:msm8916/6.12.1from
reey wants to merge 1 commit intomsm8916-mainline:msm8916/6.12.1from
Conversation
The device is a battery powered WiFi/LTE hotspot.
wonderfulShrineMaidenOfParadise
left a comment
wonderfulShrineMaidenOfParadise
left a comment
There was a problem hiding this comment.
Minor coding style check
Comment on lines
+64
to
+65
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&gpio_leds_default>; |
There was a problem hiding this comment.
Suggested change
| pinctrl-names = "default"; | |
| pinctrl-0 = <&gpio_leds_default>; | |
| pinctrl-0 = <&gpio_leds_default>; | |
| pinctrl-names = "default"; |
Comment on lines
+49
to
+50
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&gpio_keys_default>; |
There was a problem hiding this comment.
Suggested change
| pinctrl-names = "default"; | |
| pinctrl-0 = <&gpio_keys_default>; | |
| pinctrl-0 = <&gpio_keys_default>; | |
| pinctrl-names = "default"; |
Comment on lines
+133
to
+134
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&usb_id_default>; |
There was a problem hiding this comment.
Suggested change
| pinctrl-names = "default"; | |
| pinctrl-0 = <&usb_id_default>; | |
| pinctrl-0 = <&usb_id_default>; | |
| pinctrl-names = "default"; |
Comment on lines
+173
to
+176
| status = "okay"; | ||
|
|
||
| monitored-battery = <&battery>; | ||
| power-supplies = <&pm8916_charger>; |
There was a problem hiding this comment.
Suggested change
| status = "okay"; | |
| monitored-battery = <&battery>; | |
| power-supplies = <&pm8916_charger>; | |
| monitored-battery = <&battery>; | |
| power-supplies = <&pm8916_charger>; | |
| status = "okay"; |
Comment on lines
+180
to
+185
| status = "okay"; | ||
|
|
||
| monitored-battery = <&battery>; | ||
|
|
||
| qcom,fast-charge-safe-current = <900000>; | ||
| qcom,fast-charge-safe-voltage = <4300000>; |
There was a problem hiding this comment.
Suggested change
| status = "okay"; | |
| monitored-battery = <&battery>; | |
| qcom,fast-charge-safe-current = <900000>; | |
| qcom,fast-charge-safe-voltage = <4300000>; | |
| monitored-battery = <&battery>; | |
| qcom,fast-charge-safe-current = <900000>; | |
| qcom,fast-charge-safe-voltage = <4300000>; | |
| status = "okay"; |
Comment on lines
+189
to
+191
| status = "okay"; | ||
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&pwm_out>; |
There was a problem hiding this comment.
Suggested change
| status = "okay"; | |
| pinctrl-names = "default"; | |
| pinctrl-0 = <&pwm_out>; | |
| pinctrl-0 = <&pwm_out>; | |
| pinctrl-names = "default"; | |
| status = "okay"; |
Comment on lines
+206
to
+207
| status = "okay"; | ||
| extcon = <&pm8916_charger>, <&usb_otg_hack>; |
There was a problem hiding this comment.
Suggested change
| status = "okay"; | |
| extcon = <&pm8916_charger>, <&usb_otg_hack>; | |
| extcon = <&pm8916_charger>, <&usb_otg_hack>; | |
| status = "okay"; |
TravMurav
reviewed
Sep 30, 2025
| /* | ||
| * NOTE: This allows detection of custom-made OTG adapters | ||
| * | ||
| * Since L8150 doesn't support OTG it's impossible to use normal OTG |
Member
There was a problem hiding this comment.
this is not L8150. Is this true? Did you test this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device is a battery powered WiFi/LTE hotspot.