dts: qcom: msm8916-mf601xx, msm8916-mf32: initial support #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the MF32 series WiFi/LTE dongle made by Tong Heng Wei Chuang based on MSM8916. Compared to previous UFI-001C, MF32 ships more peripherals, such as battery/charger, SD Card slot, more LEDs and buttons etc. Note: The original firmware does not support 64-bit OS. It is necessary to flash 64-bit TZ firmware to boot arm64. Note: The original firmware works on 750MHz, It is necessary to downgrade cpu frequency Currently supported: - All CPU cores - Buttons - LEDs - Modem - SDHC - USB Device Mode / Host Mode - UART Signed-off-by: Coia Prant <[email protected]>
Document the new thwc,mf32-v2 device tree bindings used in their device trees. Signed-off-by: Coia Prant <[email protected]>
This commit adds support for the MF601 series WiFi/LTE dongle made by Tong Heng Wei Chuang based on MSM8916. Compared to previous UFI-001C, MF601 ships more peripherals, such as battery/charger, SD Card slot, more LEDs and buttons etc. Note: The original firmware does not support 64-bit OS. It is necessary to flash 64-bit TZ firmware to boot arm64. Note: The original firmware works on 750MHz, It is necessary to downgrade cpu frequency Currently supported: - All CPU cores - Buttons - LEDs - Modem - SDHC - USB Device Mode / Host Mode - UART Signed-off-by: Yang Xiwen <[email protected]> Tested-by: Coia Prant <[email protected]>
Document the new thwc,mf601sl-v7 device tree bindings used in their device trees. Signed-off-by: Yang Xiwen <[email protected]>
All of them already have arm64 support in mainline. But for the following reasons, it might be appropriate to add arm32 aupport: 1. arm64 is only supoorted with an updated tz. It's quite dangerous to flash tz, and it will break the downstream Android system. 2. arm64 consumes more RAM than arm32, which can not be ignored due to only 512 MiB of RAM (~320MiB available) for these devices. So add arm32 support for them, even when arm64 is available. Signed-off-by: Yang Xiwen <[email protected]> Signed-off-by: Coia Prant <[email protected]>
CoiaPrant233
force-pushed
the
msm8916/6.7-rc4
branch
from
436d126
to
392a0f5
Compare
There was a problem hiding this comment.
You will also need to sign off on every patches authored by yourself.
0003-arm64-dts-qcom-msm8916-thwc-mf601xx-Add-initial-devi.patch:333: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Coia Prant <[email protected]>'
0004-dt-bindings-qcom-Document-msm8916-thwc-mf601sl-v7.patch:28: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Coia Prant <[email protected]>'
Comment on lines
+253
to
+254
| - thwc,mf601sl-v7 | ||
| - thwc,mf32-v2 |
There was a problem hiding this comment.
- thwc,mf32-v2
- thwc,mf601sl-v7
- thwc,uf896
- thwc,ufi001c
Comment on lines
+38
to
+42
| qcom-msm8916-thwc-uf896.dtb \ | ||
| qcom-msm8916-thwc-ufi001c.dtb \ | ||
| qcom-msm8916-thwc-mf601sl-v7.dtb \ | ||
| qcom-msm8916-thwc-mf32-v2.dtb \ | ||
| qcom-msm8916-yiming-uz801v3.dtb \ |
There was a problem hiding this comment.
Suggested change
| qcom-msm8916-thwc-uf896.dtb \ | |
| qcom-msm8916-thwc-ufi001c.dtb \ | |
| qcom-msm8916-thwc-mf601sl-v7.dtb \ | |
| qcom-msm8916-thwc-mf32-v2.dtb \ | |
| qcom-msm8916-yiming-uz801v3.dtb \ | |
| qcom-msm8916-thwc-mf32-v2.dtb \ | |
| qcom-msm8916-thwc-mf601sl-v7.dtb \ | |
| qcom-msm8916-thwc-uf896.dtb \ | |
| qcom-msm8916-thwc-ufi001c.dtb \ | |
| qcom-msm8916-yiming-uz801v3.dtb \ |
Comment on lines
+65
to
+66
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-mf601sl-v7.dtb | ||
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-mf32-v2.dtb |
There was a problem hiding this comment.
dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-mf32-v2.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-mf601sl-v7.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-uf896.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-ufi001c.dtb
| }; | ||
|
|
||
| &leds { | ||
| led-wan-green { |
There was a problem hiding this comment.
Sort the nodes in alphabetical order or GPIO pins.
| }; | ||
|
|
||
| &leds { | ||
| led-wan-green { |
| @@ -0,0 +1,3 @@ | |||
| // SPDX-License-Identifier: GPL-2.0-only | |||
| #include "arm64/qcom/msm8916-thwc-mf32-v2.dts" | |||
| #include "qcom-msm8916-smp.dtsi" | |||
There was a problem hiding this comment.
A bit of weird without newline.
TravMurav
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Please also check what checkpatch complains about.
Also probably want to look at the commit authorship since I see two s-o-b on most of them but i.e. no Co-developed-by: or [changelog] note to show why two people handled these commits.
So please:
- Make sure all commits have s-o-b of the author.
- If you want to give additional attribution to Yang, add either:
Co-developed-by:+ s-o-b from Yang (or from you if Yang is suppsed to be the Author:), or- a note like
[Coia: Added x y z]+ s-o-b
Thanks for working on this!
|
|
||
| /dts-v1/; | ||
|
|
||
| #include "msm8916-thwc-mf32.dtsi" |
There was a problem hiding this comment.
Would this dtsi be used by some other device later? You may want to motivate this in the commit message.
| @@ -250,6 +250,7 @@ properties: | |||
| - samsung,serranove | |||
| - thwc,uf896 | |||
| - thwc,ufi001c | |||
| - thwc,mf32-v2 | |||
There was a problem hiding this comment.
Please reorder commits so that the dt-bindings is always before the usage of the binding (i.e. first bindings then dts that uses it)
| @@ -62,6 +62,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-on7.dtb | |||
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb | |||
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-uf896.dtb | |||
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-ufi001c.dtb | |||
| dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-mf601sl-v7.dtb | |||
There was a problem hiding this comment.
Authorship on this commit looks weird weird...
From e0513f159f005d12f1ba91716bc4f0b405498059 Mon Sep 17 00:00:00 2001
From: Coia Prant <[email protected]>
Date: Sat, 15 Jun 2024 10:24:54 +0000
Subject: [PATCH] arm64: dts: qcom: msm8916-thwc-mf601xx: Add initial device
tree
...
Signed-off-by: Yang Xiwen <[email protected]>
Tested-by: Coia Prant <[email protected]>
You're designated as an author but sob is from Yang, then there is your tested-by, which looks weird as author's testing their own patch is implied...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous pull request see #329 #310
Tested MF601SL_CT_V07 and MF32_MB_V2 devices.