arm64: dts: qcom: msm8916-samsung-heatqlte: Add touchkeys #356
Conversation
| pinctrl-names = "default"; | ||
| }; | ||
|
|
||
| i2c_touchkey: i2c-touchkey { |
There was a problem hiding this comment.
| i2c_touchkey: i2c-touchkey { | |
| i2c-touchkey { |
Don't think anything would use this label
| interrupt-parent = <&tlmm>; | ||
| interrupts = <9 IRQ_TYPE_EDGE_RISING>; |
There was a problem hiding this comment.
I think interrupts-extended is preferred nowdays
| vcc-supply = <®_vcc_touchkey>; | ||
| vdd-supply = <®_vdd_touchkey_led>; | ||
|
|
||
| linux,keycodes = <KEY_APPSELECT KEY_BACK>; |
There was a problem hiding this comment.
I'd move this last since it's a vendor property (even if vendor is linux in this case)
| bias-disable; | ||
| }; | ||
|
|
||
| nfc_touchkey_default: nfc-touchkey-default-state { |
|
Oops, I was glancing at msm8916-samsung-gprime-common.dtsi as a reference for the i2c-gpio usage and that's where I mixed up "nfc" from! |
| linux,keycodes = <KEY_APPSELECT KEY_BACK>; | ||
| }; | ||
| }; | ||
|
|
celele64
force-pushed
the
celele/msm8916/6.7-rc4-wip-touchkeys
branch
from
72915f9
to
13b110b
Compare
| pinctrl-names = "default"; | ||
| }; | ||
|
|
||
| i2c-touchkey { |
There was a problem hiding this comment.
The nodes are supposed to be sorted in alphabetical order.
| }; | ||
|
|
||
| &tlmm { | ||
| vdd_touchkey_default: vdd-touchkey-default-state { |
| }; | ||
| }; | ||
|
|
||
| &tlmm { |
There was a problem hiding this comment.
&tlmm is preferred to be put at the bottom/end of the device tree for msm8916 devices.
|
Try branch |
Add support for the tm2-touchkey input device providing the menu and back keys and their backlight leds. Signed-off-by: Celeste Lucero <[email protected]>
celele64
force-pushed
the
celele/msm8916/6.7-rc4-wip-touchkeys
branch
from
13b110b
to
eba92b3
Compare
|
Okay, I'll try this dts on |
|
6.7 is deprecated. Development is preferred with latest kernel, which makes it "mainline". Besides 6.7 has been released and there is no point to use 6.7-rc* branches. |
|
Makes sense, thanks for the heads up I see no dts for heatqlte at Sorry for the total newbie questions -.-' |
Hi! This is my first time contributing to kernel-adjacent projects so please teach me the ways as you find necessary, I'm all up for learning.
This devicetree patch enables the Cypress tm2-touchkey device controlling the menu and back keys in the Samsung heatqlte (SM-G357FZ) and their backlight leds
Since GPIOs 8 and 10 have no hardware I2C interface software emulation is used via i2c-gpio, just like in the downstream kernel
I've set up the pinctrl as well, however I'm yet to learn more about this subsystem. Please point out anything I may have done wrong
Thanks!