Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motorola Surnia Backlight Driver V2 #296

Draft
wants to merge 4 commits into
base: msm8916/6.2-rc5
Choose a base branch
from

Conversation

BogdanTheGeek
Copy link

Added support for brightness control for motorola-surnia (sprey and styx too) though led-backlight driver and rohm bd65b60 driver.

Re-submission of #284

I re-wrote the driver from scratch, it was more fun than I expected. Hopefully this time its easier to review. I've done my best to check the coding standards, examples and old PRs for guidance.

Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks

drivers/leds/leds-bd65b60.c Outdated Show resolved Hide resolved
drivers/leds/leds-bd65b60.c Outdated Show resolved Hide resolved
drivers/leds/leds-bd65b60.c Outdated Show resolved Hide resolved
drivers/leds/leds-bd65b60.c Show resolved Hide resolved
drivers/leds/leds-bd65b60.c Outdated Show resolved Hide resolved
include/dt-bindings/leds/leds-bd65b60.h Outdated Show resolved Hide resolved
Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the usual commit order is bindings then driver then dt changes adding users

include/dt-bindings/leds/leds-bd65b60.h Outdated Show resolved Hide resolved
include/dt-bindings/leds/leds-bd65b60.h Outdated Show resolved Hide resolved
@BogdanTheGeek
Copy link
Author

BogdanTheGeek commented Mar 8, 2023

Re-ordered the commits, but I assume that only the first 2 will be upstreamed and the dts will go into pmaports.

Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driver commit is still before the dt-bindings, please swap them around

drivers/leds/leds-bd65b60.c Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts Outdated Show resolved Hide resolved
@BogdanTheGeek BogdanTheGeek force-pushed the surnia/backlight2 branch 2 times, most recently from 20a27d4 to bb2077e Compare March 8, 2023 13:55
@BogdanTheGeek BogdanTheGeek force-pushed the surnia/backlight2 branch 2 times, most recently from 4882044 to 114ac8e Compare March 8, 2023 14:50
Added documentation for the rohm,bd65b60 led driver.

Signed-off-by: Bogdan Ionescu <[email protected]>
The chip supports 2 outpus sharing the same current setting
and is controlled over I2C.

Signed-off-by: Bogdan Ionescu <[email protected]>
Enabling backlight brightness control for motorola-surnia.

Signed-off-by: Bogdan Ionescu <[email protected]>
Based on motorola-surnia, the only changes being:
 - Using LED2 instead of LED1 for the led driver
 - Using GPIO 113 for the backlight reset

Signed-off-by: Bogdan Ionescu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants