-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming #258
base: wip/msm8916/6.9
Are you sure you want to change the base?
arm64: dts: qcom: msm8916-samsung-j5-common: Upstreaming #258
Conversation
a154b79
to
90b1f97
Compare
|
||
led-max-microamp = <300000>; | ||
flash-max-microamp = <1500000>; | ||
flash-max-timeout-us = <1835000>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious mostly, where are these values coming from? Or are they just made up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainl1ne@20c0f7c#diff-92c2357e6d8e3028d5884f443969796f7d690bd991dc913f8f1fdd23575c14b2R219-R221
They are copied values and I am not sure what they do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @nergzd723 can share where they are coming from. I failed to find them in a obvious way downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe downstream KTD2692_MOVIE_CURRENT4 and KTD2692_FLASH_CURRENT16 would match those values. I don't remember how I converted it to uA, exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't really understand it, but I guess I'm fine with it as long as you make sure that it works properly :)
90b1f97
to
aed7cf5
Compare
aed7cf5
to
50db6ab
Compare
a91a84b
to
e0f0936
Compare
e0f0936
to
7e5ac50
Compare
7e5ac50
to
b7bbeb3
Compare
b7bbeb3
to
38a761c
Compare
I'm not sure what happened, but testing the modified source from on my SM-J500H (3g variant, codename j5), the touchscreen works, but the modem seems to not work, specifically it doesn't detect my SIM card, but otherwise seems to work fine. |
@ap4ss3rby I don't see modem regressions for now. Does it always or sometimes happen? |
Well I was testing with a nanoSIM, and since the phone has a slot loading microSIM I wasn't pushing the sim into the socket completely, so it seems like its mostly my fault for not inserting it fully (or not using a SIM adapter), otherwise it seems to be working fine (including only recognizing that my phone is 3g only) |
38a761c
to
e35c6f4
Compare
063bbd9
to
8990bb5
Compare
8990bb5
to
34242d4
Compare
98939cb
to
c4d3662
Compare
a23db8e
to
286951b
Compare
e7a0931
to
903e6f0
Compare
286951b
to
0b0b520
Compare
19cb01e
to
349abab
Compare
0b0b520
to
d69fe2e
Compare
224cef4
to
f8e8fc2
Compare
d69fe2e
to
66e6840
Compare
There are regressions found in KTD2692 driver. b5a8c50 needs to be reverted to get front torch working. |
eb39f23
to
fc59a46
Compare
66e6840
to
2fe97a1
Compare
77359bc
to
f1299dc
Compare
… jack detection (v2)" This reverts commit d4d1155. Signed-off-by: Lin, Meng-Bo <[email protected]>
…(v4)" This reverts commit 3139bdd. Signed-off-by: Lin, Meng-Bo <[email protected]>
This reverts commit 17fc4f5. Signed-off-by: Lin, Meng-Bo <[email protected]>
This reverts commit 708d958. Signed-off-by: Lin, Meng-Bo <[email protected]>
…(v2)" This reverts commit 742fd5a. Signed-off-by: Lin, Meng-Bo <[email protected]>
…l (v4)" This reverts commit 65f020f. Signed-off-by: Lin, Meng-Bo <[email protected]>
This reverts commit a7dee29. Signed-off-by: Lin, Meng-Bo <[email protected]>
J5 and J5X uses KTD2692 Flash LED driver. Add it to the device tree. Signed-off-by: Markuss Broks <[email protected]> [Apply for msm8916-samsung-j5x] v2: status = "okay"; by default Signed-off-by: Lin, Meng-Bo <[email protected]>
v2: Make reset-gpios GPIO_ACTIVE_LOW v3: Add &mdss { status = "okay"; }; Signed-off-by: Markuss Broks <[email protected]> v4: Move from msm8916-samsung-j5 Signed-off-by: Lin, Meng-Bo <[email protected]>
v2: Move ®_vdd_lcd_3p0 from common dtsi Signed-off-by: Lin, Meng-Bo <[email protected]>
…tection (v2) v2: Moved from msm8916-samsung-j5x Headset microphone is broken with this on j5x, headphone buttons are broken as well. (Needs more investigation...) Signed-off-by: Lin, Meng-Bo <[email protected]>
…e tree This common dtsi adds support for msm8916 variant of Samsung Galaxy J3 smartphones released in 2016. Add a device tree for J3 with initial support for: - GPIO keys - SDHCI (internal and external storage) - USB Device Mode - UART (on USB connector via the SM5703 MUIC) - WCNSS (WiFi/BT) - Regulators Signed-off-by: Lin, Meng-Bo <[email protected]>
v2: Use msm8916-samsung-j5-common v3: Use msm8916-samsung-j3-common Signed-off-by: Lin, Meng-Bo <[email protected]>
J3 has ST LIS2HH12 accelerometer. Add support for it. v2: Change interrupt to IRQ_TYPE_LEVEL_HIGH Signed-off-by: Stephan Gerhold <[email protected]> v3: Move from msm8916-samsung-j5. Set vdd-supply to l5 Signed-off-by: Lin, Meng-Bo <[email protected]>
Add regulators for the panel on J3. Note that l17 is required. Signed-off-by: Lin, Meng-Bo <[email protected]>
2fe97a1
to
3d7ef2e
Compare
AddDrop j3 in upstreamsamsung-j3
to upstream, and include it inmsm8916-mainline
Add touchscreen to upstream patches Drop touchscreen in upstreamUpstreamed touchscreen partially.msm8916-samsung-j3-common.dtsi
Link:
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/lkml/[email protected]/