Skip to content

Commit

Permalink
leds: Add support for rohm,bd65b60 led driver
Browse files Browse the repository at this point in the history
This driver is used in a few Motorola phones from 2015, and this commit aims
to improve the mainline kernel support for these devices.

Signed-off-by: Bogdan Ionescu <[email protected]>
  • Loading branch information
BogdanTheGeek committed Mar 6, 2023
1 parent 02dad76 commit 44deb6c
Show file tree
Hide file tree
Showing 3 changed files with 294 additions and 0 deletions.
11 changes: 11 additions & 0 deletions drivers/leds/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -736,6 +736,17 @@ config LEDS_BLINKM
This option enables support for the BlinkM RGB LED connected
through I2C. Say Y to enable support for the BlinkM LED.

config LEDS_BD65B60
tristate "LED Driver for BD65B60"
depends on LEDS_CLASS
depends on I2C
help
If you have a LCD backlight connected to the ROHM BD65B60,
say Y here to enable this driver.

To compile this driver as a module, choose M here: the module will
be called leds-bd65b60.

config LEDS_POWERNV
tristate "LED support for PowerNV Platform"
depends on LEDS_CLASS
Expand Down
1 change: 1 addition & 0 deletions drivers/leds/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ obj-$(CONFIG_LEDS_AW2013) += leds-aw2013.o
obj-$(CONFIG_LEDS_BCM6328) += leds-bcm6328.o
obj-$(CONFIG_LEDS_BCM6358) += leds-bcm6358.o
obj-$(CONFIG_LEDS_BD2802) += leds-bd2802.o
obj-$(CONFIG_LEDS_BD65B60) += leds-bd65b60.o
obj-$(CONFIG_LEDS_BLINKM) += leds-blinkm.o
obj-$(CONFIG_LEDS_CLEVO_MAIL) += leds-clevo-mail.o
obj-$(CONFIG_LEDS_COBALT_QUBE) += leds-cobalt-qube.o
Expand Down
282 changes: 282 additions & 0 deletions drivers/leds/leds-bd65b60.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,282 @@
// SPDX-License-Identifier: GPL-2.0+
/*
* Simple driver for ROHM Semiconductor BD65B60GWL Backlight driver chip
*
* Copyright (C) 2014 ROHM Semiconductor.com
* Copyright (C) 2014 MMI
* Copyright (C) 2023 Bogdan Ionescu <[email protected]>
*/

#include <linux/i2c.h>
#include <linux/leds.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/regmap.h>
#include <linux/slab.h>

#define BD65B60_MAX_BRIGHTNESS 255
#define BD65B60_DEFAULT_BRIGHTNESS 255
#define BD65B60_DEFAULT_TRIGGER "bkl-trigger"
#define BD65B60_DEFAULT_NAME "white"
#define BD65B60_DEFAULT_OVP_VAL BD65B60_35V_OVP

#define INT_DEBOUNCE_MSEC 10

#define PWMEN_MASK 0x20
#define OVP_MASK 0x18
#define LEDSEL_MASK 0x05

enum bd65b60_regs {
REG_SFTRST = 0x00,
REG_COMSET1 = 0x01,
REG_COMSET2 = 0x02,
REG_LEDSEL = 0x03,
REG_ILED = 0x05,
REG_CTRLSET = 0x07,
REG_SLEWSET = 0x08,
REG_PON = 0x0E,
REG_MAX = REG_PON,
};

enum bd65b60_ovp {
BD65B60_25V_OVP = 0x00,
BD65B60_30V_OVP = 0x08,
BD65B60_35V_OVP = 0x10,
};

enum bd65b60_ledsel {
BD65B60_DISABLE = 0x00,
BD65B60_LED1SEL = 0x01,
BD65B60_LED2SEL = 0x04,
BD65B60_LED12SEL = 0x05,
};

enum bd65b60_pwm_ctrl {
BD65B60_PWM_DISABLE = 0x00,
BD65B60_PWM_ENABLE = 0x20,
};

enum bd65b60_state {
BD65B60_OFF = 0,
BD65B60_ON = 1,
BD65B60_KEEP = 2,
};

struct bd65b60_led {
struct led_classdev cdev;
struct i2c_client *client;
struct regmap *regmap;
struct mutex lock;
enum bd65b60_ledsel enable;
enum bd65b60_state state;
enum bd65b60_ovp ovp;
};

static const struct regmap_config bd65b60_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.max_register = REG_MAX,
};

static void bd65b60_brightness_set(struct led_classdev *cdev,
enum led_brightness brightness)
{
int ret;
enum bd65b60_state new_state;
struct bd65b60_led *led = container_of(cdev, struct bd65b60_led, cdev);

mutex_lock(&led->lock);

ret = regmap_write(led->regmap, REG_ILED, brightness);

new_state = (brightness) ? BD65B60_ON : BD65B60_OFF;

if (new_state != led->state) {
ret |= regmap_write(led->regmap, REG_PON, new_state);
led->state = new_state;
}

mutex_unlock(&led->lock);

if (ret)
dev_err(&led->client->dev, "Failed to set brightness: %d", ret);
}

static int bd65b60_init(struct bd65b60_led *led)
{
int ret;

mutex_lock(&led->lock);

if (led->state != BD65B60_KEEP) {
/* Reset the chip */
ret = regmap_write(led->regmap, REG_SFTRST, 0x01);
}

ret |= regmap_update_bits(led->regmap, REG_COMSET1, OVP_MASK, led->ovp);
ret |= regmap_update_bits(led->regmap, REG_LEDSEL, LEDSEL_MASK,
led->enable);
ret |= regmap_update_bits(led->regmap, REG_CTRLSET, PWMEN_MASK,
BD65B60_PWM_ENABLE);
ret |= regmap_write(led->regmap, REG_PON,
led->state ? BD65B60_ON : BD65B60_OFF);

mutex_unlock(&led->lock);

return ret;
}

static int bd65b60_parse_dt(struct bd65b60_led *led,
struct fwnode_handle **fwnode)
{
struct device *dev = &led->client->dev;
struct fwnode_handle *child = NULL;
char default_state[] = "keep";
int ret;

child = device_get_next_child_node(dev, child);
if (!child) {
dev_err(dev, "No led child node found");
return -ENODEV;
}

/* Check required properties */
if (!fwnode_property_present(child, "rohm,enable")) {
dev_err(dev, "No reg property found");
return -ENOENT;
}

ret = fwnode_property_read_u32(child, "rohm,enable", &led->enable);
if (ret || (led->enable & LEDSEL_MASK) != led->enable) {
dev_err(dev, "Failed to read enable property");
return ret;
}

/* Check optional properties */
led->state = BD65B60_OFF;
if (!fwnode_property_present(child, "default-state")) {
ret = fwnode_property_read_string(child, "default-state",
(const char **)&default_state);
if (ret) {
dev_err(dev, "Failed to read default-state property");
return ret;
}

if (strcmp(default_state, "keep") == 0) {
led->state = BD65B60_KEEP;
} else if (strcmp(default_state, "on") == 0) {
led->state = BD65B60_ON;
} else if (strcmp(default_state, "off") == 0) {
led->state = BD65B60_OFF;
} else {
dev_err(dev, "Invalid default-state property");
return -EINVAL;
}
}

led->ovp = BD65B60_DEFAULT_OVP_VAL;
if (fwnode_property_present(child, "rohm,ovp")) {
ret = fwnode_property_read_u32(child, "rohm,ovp", &led->ovp);

if (ret || (led->ovp & OVP_MASK) != led->ovp) {
dev_err(dev, "Failed to read ovp property");
return ret;
}
}

*fwnode = child;

return 0;
}

static int bd65b60_probe(struct i2c_client *client)
{
struct bd65b60_led *led;
struct led_init_data init_data = {};
struct fwnode_handle *fwnode = NULL;
int ret;

led = devm_kzalloc(&client->dev, sizeof(*led), GFP_KERNEL);
if (!led)
return -ENOMEM;

led->client = client;
i2c_set_clientdata(client, led);

ret = bd65b60_parse_dt(led, &fwnode);
if (ret)
return ret;

led->cdev.name = BD65B60_DEFAULT_NAME;
led->cdev.brightness_set = bd65b60_brightness_set;
led->cdev.brightness = BD65B60_DEFAULT_BRIGHTNESS;
led->cdev.max_brightness = BD65B60_MAX_BRIGHTNESS;
led->cdev.default_trigger = BD65B60_DEFAULT_TRIGGER;
led->client = client;

led->regmap = devm_regmap_init_i2c(client, &bd65b60_regmap_config);
if (IS_ERR(led->regmap)) {
ret = PTR_ERR(led->regmap);
dev_err(&client->dev, "Failed to allocate register map: %d",
ret);
return ret;
}

mutex_init(&led->lock);

ret = bd65b60_init(led);
if (ret) {
dev_err(&client->dev, "Failed to initialize led: %d", ret);
return ret;
}

init_data.fwnode = fwnode;
init_data.devicename = led->client->name;
init_data.default_label = ":";
ret = devm_led_classdev_register_ext(&client->dev, &led->cdev,
&init_data);
if (ret) {
dev_err(&client->dev, "Failed to register led: %d", ret);
return ret;
}

dev_info(&client->dev, "BD65B60 LED driver initialized");

return 0;
}

static void bd65b60_remove(struct i2c_client *client)
{
struct bd65b60_led *led = i2c_get_clientdata(client);

if (regmap_write(led->regmap, REG_PON, BD65B60_OFF))
dev_err(&client->dev, "Failed to turn off led");
}

static const struct i2c_device_id bd65b60_id[] = {
{ "bd65b60", 0 },
{},
};
MODULE_DEVICE_TABLE(i2c, bd65b60_id);

static const struct of_device_id of_bd65b60_leds_match[] = {
{ .compatible = "rohm,bd65b60" },
{},
};
MODULE_DEVICE_TABLE(of, of_bd65b60_leds_match);

static struct i2c_driver bd65b60_i2c_driver = {
.driver = {
.name = "bd65b60",
.owner = THIS_MODULE,
.of_match_table = of_match_ptr(of_bd65b60_leds_match),
},
.probe_new = bd65b60_probe,
.remove = bd65b60_remove,
.id_table = bd65b60_id,
};

module_i2c_driver(bd65b60_i2c_driver);

MODULE_DESCRIPTION("ROHM Semiconductor led driver for bd65b60");
MODULE_LICENSE("GPL");

0 comments on commit 44deb6c

Please sign in to comment.