Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor issues in logic for dsl2 #975

Closed
anoronh4 opened this issue Oct 3, 2022 · 0 comments · Fixed by #979
Closed

minor issues in logic for dsl2 #975

anoronh4 opened this issue Oct 3, 2022 · 0 comments · Fixed by #979
Assignees
@anoronh4
Labels
bug Something isn't working
Milestone
2.0

Comments

@anoronh4
Copy link
Collaborator

anoronh4 commented Oct 3, 2022

this issue is to track minor some minor bugs in the workflow logic in dsl2.nf:
https://github.com/mskcc/tempo/blob/develop/dsl2.nf#L57-L73

  1. In line 57, all workflows should be lowercase, for example germSV won't work because the following lines are testing for germsv
  2. in line 68 the mutsig option should not turn on the lohhla workflow.

We can continue to track any similar minor issues here.
@gongyixiao gongyixiao added this to the 2.0 milestone Oct 12, 2022
@anoronh4 anoronh4 added the bug Something isn't working label Dec 19, 2022
@anoronh4 anoronh4 self-assigned this Dec 21, 2022
@anoronh4 anoronh4 mentioned this issue Dec 22, 2022
Merged
@anoronh4 anoronh4 linked a pull request Dec 22, 2022 that will close this issue
Bugfix/workflow logic issues #979
Merged
@gongyixiao gongyixiao mentioned this issue Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anoronh4 anoronh4

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Bugfix/workflow logic issues mskcc/tempo
2 participants
@gongyixiao @anoronh4