Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove target from input of alignment steps #888

Open
anoronh4 opened this issue Mar 25, 2021 · 1 comment
Open

remove target from input of alignment steps #888

anoronh4 opened this issue Mar 25, 2021 · 1 comment
Labels
alignment related to generation of the bam file backburner probably won't address in a near future

Comments

@anoronh4
Copy link
Collaborator

target is used as input for several alignment processes even though it is not used in the process. This could cause several steps to be re-run if target changes, even though they are not relevant to those steps. It might be helpful to remove target from channels for before SplitLanes or AlignReads steps, and then join the target back into the output channel after BQSR.

@anoronh4 anoronh4 added backburner probably won't address in a near future alignment related to generation of the bam file labels Mar 25, 2021
@gongyixiao
Copy link
Collaborator

This is a good point. The only process that uses target information is QcCollectHsMetrics

The ideal case is we don't need target column in fastq mapping.tsv at all. And the target info will be passed in only when QcCollectHsMetrics is enabled. But I'm not sure how we could achieve that without having another input tsv file, which will create another layer of complexity again. Not sure if the benefits worth the complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alignment related to generation of the bam file backburner probably won't address in a near future
Projects
None yet
Development

No branches or pull requests

2 participants