Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: implement surface-invalidation-v1 #13546

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

llyyr
Copy link
Contributor

@llyyr llyyr commented Feb 24, 2024

Needed for the next commit
@Dudemanguy
Copy link
Member

Probably want to destroy the wp_surface_invalidation objects on uninit.

This allows mpv to recover from gpu resets if the compositor supports
the protocol
@llyyr
Copy link
Contributor Author

llyyr commented Feb 24, 2024

Probably want to destroy the wp_surface_invalidation objects on uninit.

Thanks, forgot about that

@Nefsen402
Copy link

Nefsen402 commented Feb 25, 2024

Surface invalidation doesn't just get invoked when a gpu reset happens but also doesn't necessarily mean it will ever get invoked (eg multigpu - the surface can be recovered from a blit from another GPU). Surface invalidation also has its uses in hotplug multi-gpu so recreating the entire vo seems a little bit too much for that. Ideally, robustness would just be hooked up but I don't think it matters all that much at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants