3: Job Selection Refactor / Fix #9180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
force-pushed
the
camd/pr3-job-selection-fix
branch
from
59482fc to
a42feba
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9180 +/- ##
==========================================
+ Coverage 82.05% 82.49% +0.43%
==========================================
Files 602 606 +4
Lines 33794 33986 +192
Branches 3017 3273 +256
==========================================
+ Hits 27731 28036 +305
+ Misses 5938 5827 -111
+ Partials 125 123 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Update pnpm version - Optimize tests and docker configuration - Add markdown formatting scripts and fix lint errors - Upgrade packages - Fix deprecations with defaultProps - Fix React console warnings for duplicate keys and null props Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Fix fragile selectJob approach by converting to functional components - Use safer instance tracking approach - Add Zustand migration notes for future reference - Add unit tests for job selection hooks and helpers Co-Authored-By: Claude Opus 4.5 <[email protected]>
camd
force-pushed
the
camd/pr3-job-selection-fix
branch
3 times, most recently
from
cea32b3 to
61c33ed
Compare
camd
force-pushed
the
camd/pr3-job-selection-fix
branch
from
61c33ed to
f6265c6
Compare
Fixes race condition where clicking jobs would sometimes close the
details panel instead of opening it. Two issues were addressed:
1. Dual source of truth: Redux state and URL were updated separately
in async actions, causing timing issues. Now all selection flows
through URL first, with a single sync effect updating Redux state.
2. Event handler mismatch: onMouseDown used closest('[data-job-id]')
but onClick clear check used closest('button'). Added data-job-id
check to clearIfEligibleTarget to prevent clearing on job clicks.
Co-Authored-By: Claude Opus 4.5 <[email protected]>
camd
force-pushed
the
camd/pr3-job-selection-fix
branch
from
f6265c6 to
350427a
Compare
Collaborator
Author
|
Need to ensure that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 3: camd/pr3-job-selection-fix (based on PR 2)
useJobButtonRegistry/useDebounce