chore: Enable the clippy create_dir lint
#2315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
==========================================
- Coverage 93.33% 93.33% -0.01%
==========================================
Files 114 114
Lines 36897 36897
Branches 36897 36897
==========================================
- Hits 34439 34438 -1
Misses 1675 1675
- Partials 783 784 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 5c36c79. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 5c36c79. decode 4096 bytes, mask ff: No change in performance detected. time: [11.192 µs 11.227 µs 11.269 µs]
change: [-0.2850% +0.1055% +0.5361%] (p = 0.63 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.8856 ms 2.8939 ms 2.9038 ms]
change: [-0.6885% -0.1837% +0.3266%] (p = 0.48 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.573 µs 19.628 µs 19.685 µs]
change: [-0.1499% +0.2531% +0.7422%] (p = 0.25 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0679 ms 5.0795 ms 5.0925 ms]
change: [-0.1448% +0.1767% +0.5030%] (p = 0.29 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5298 µs 5.5474 µs 5.5715 µs]
change: [-3.4000% -0.7968% +0.9305%] (p = 0.66 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.4139 ms 1.4194 ms 1.4263 ms]
change: [-0.5984% -0.0149% +0.5792%] (p = 0.89 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.854 ns 99.155 ns 99.463 ns]
change: [-0.0056% +0.3635% +0.7499%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.84 ns 117.14 ns 117.46 ns]
change: [-0.9349% -0.2542% +0.2710%] (p = 0.46 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.57 ns 117.06 ns 117.63 ns]
change: [-0.4272% +0.1606% +0.7572%] (p = 0.62 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.509 ns 100.67 ns 107.79 ns]
change: [-0.7555% +3.5887% +12.956%] (p = 0.42 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.70 ms 111.75 ms 111.81 ms]
change: [-0.3506% -0.2858% -0.2158%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4436 µs 5.5462 µs 5.6509 µs]
change: [-0.8386% +1.7535% +4.7049%] (p = 0.22 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [41.613 ms 41.686 ms 41.762 ms]
change: [-1.3255% -1.0874% -0.8268%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [41.872 ms 41.941 ms 42.010 ms]
change: [-1.2356% -0.9723% -0.7361%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [41.294 ms 41.357 ms 41.420 ms]
change: [-2.3190% -2.1257% -1.9186%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [41.659 ms 41.723 ms 41.786 ms]
change: [-0.9537% -0.7435% -0.5390%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💔 Performance has regressed. time: [908.54 ms 918.96 ms 929.53 ms]
thrpt: [107.58 MiB/s 108.82 MiB/s 110.07 MiB/s]
change:
time: [+1.2069% +2.7717% +4.2650%] (p = 0.00 < 0.05)
thrpt: [-4.0905% -2.6970% -1.1925%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [302.50 ms 304.81 ms 307.18 ms]
thrpt: [32.554 Kelem/s 32.808 Kelem/s 33.058 Kelem/s]
change:
time: [-0.5658% +0.5847% +1.7687%] (p = 0.32 > 0.05)
thrpt: [-1.7379% -0.5813% +0.5690%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.292 ms 34.458 ms 34.643 ms]
thrpt: [28.866 elem/s 29.021 elem/s 29.162 elem/s]
change:
time: [-0.3746% +0.3773% +1.1457%] (p = 0.33 > 0.05)
thrpt: [-1.1327% -0.3759% +0.3760%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [1.6791 s 1.6990 s 1.7192 s]
thrpt: [58.166 MiB/s 58.859 MiB/s 59.557 MiB/s]
change:
time: [+1.4986% +3.0186% +4.5607%] (p = 0.00 < 0.05)
thrpt: [-4.3618% -2.9302% -1.4764%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/index.html#create_dir