fix: Simplify neqo_common::log and enforce clippy format checks
#2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
- Coverage 93.33% 93.01% -0.33%
==========================================
Files 114 114
Lines 36897 36842 -55
Branches 36897 36842 -55
==========================================
- Hits 34439 34268 -171
- Misses 1675 1789 +114
- Partials 783 785 +2 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 17129d4. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Nit: Remove trailing dots to make messages more consistent.
larseggert
changed the title
neqo_common::log with log crate
larseggert
changed the title
neqo_common::log with log crateneqo_common::log and enforce clippy format checks
Signed-off-by: Lars Eggert <[email protected]>
Benchmark resultsPerformance differences relative to 5c36c79. decode 4096 bytes, mask ff: No change in performance detected. time: [11.163 µs 11.201 µs 11.245 µs]
change: [-0.5439% -0.1661% +0.2089%] (p = 0.40 > 0.05)
decode 1048576 bytes, mask ff: Change within noise threshold. time: [2.9220 ms 2.9316 ms 2.9427 ms]
change: [+0.6009% +1.1171% +1.6278%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.534 µs 19.585 µs 19.643 µs]
change: [-0.2792% +0.1245% +0.5585%] (p = 0.56 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0505 ms 5.0631 ms 5.0763 ms]
change: [-0.4835% -0.1467% +0.1790%] (p = 0.39 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5248 µs 5.5441 µs 5.5706 µs]
change: [-3.6013% -1.0380% +0.5758%] (p = 0.54 > 0.05)
decode 1048576 bytes, mask 3f: Change within noise threshold. time: [1.4124 ms 1.4125 ms 1.4126 ms]
change: [-0.9771% -0.5007% -0.1121%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.434 ns 99.729 ns 100.03 ns]
change: [+0.5217% +0.8786% +1.2377%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [118.22 ns 118.53 ns 118.92 ns]
change: [+0.4018% +1.1194% +1.7086%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [118.17 ns 118.72 ns 119.36 ns]
change: [+0.9839% +1.9148% +3.1238%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.186 ns 98.323 ns 98.485 ns]
change: [-0.1645% +0.8891% +1.9597%] (p = 0.10 > 0.05)
RxStreamOrderer::inbound_frame(): 💚 Performance has improved. time: [110.81 ms 110.87 ms 110.92 ms]
change: [-1.1435% -1.0794% -1.0159%] (p = 0.00 < 0.05)
SentPackets::take_ranges: Change within noise threshold. time: [5.4996 µs 5.6775 µs 5.8701 µs]
change: [+0.2334% +2.7084% +5.4015%] (p = 0.04 < 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [42.313 ms 42.399 ms 42.486 ms]
change: [+0.3382% +0.6049% +0.8750%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.671 ms 42.748 ms 42.826 ms]
change: [+0.6710% +0.9324% +1.1922%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [42.476 ms 42.531 ms 42.588 ms]
change: [+0.4537% +0.6547% +0.8410%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [42.364 ms 42.426 ms 42.486 ms]
change: [+0.7093% +0.9305% +1.1270%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [864.74 ms 873.15 ms 881.82 ms]
thrpt: [113.40 MiB/s 114.53 MiB/s 115.64 MiB/s]
change:
time: [-3.6780% -2.3514% -1.0336%] (p = 0.00 < 0.05)
thrpt: [+1.0444% +2.4080% +3.8184%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: 💔 Performance has regressed. time: [316.28 ms 318.45 ms 320.67 ms]
thrpt: [31.184 Kelem/s 31.402 Kelem/s 31.618 Kelem/s]
change:
time: [+3.9751% +5.0865% +6.2172%] (p = 0.00 < 0.05)
thrpt: [-5.8533% -4.8403% -3.8231%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.399 ms 34.585 ms 34.788 ms]
thrpt: [28.745 elem/s 28.914 elem/s 29.070 elem/s]
change:
time: [-0.0465% +0.7458% +1.5559%] (p = 0.07 > 0.05)
thrpt: [-1.5321% -0.7402% +0.0465%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [1.7325 s 1.7516 s 1.7708 s]
thrpt: [56.471 MiB/s 57.090 MiB/s 57.720 MiB/s]
change:
time: [+4.6788% +6.2100% +7.6367%] (p = 0.00 < 0.05)
thrpt: [-7.0949% -5.8469% -4.4696%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move variables into format strings where possible and make some other minor improvements.
Offshoot off #1963.