Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-4092: Add component to illustrate the removal flow #5702

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Mar 14, 2025

References:

Jira: MNTOR-4092
Figma: https://www.figma.com/design/eyMvbuBeUvjnelDNGa8Mdb/Dashboard-visualization?node-id=950-39509&m=dev

Description

This component is going to be used for the new in-progress dashboard. Note that it's slightly different from the designs, in that the chevrons don't have rounded corners - I couldn't find a way to do that. I'm hoping that UX will be fine with that :)

@codemist I'm not sure if it makes sense to group this under "Molecules" in Storybook, but I didn't know where else to put it. Let me know if you have a better suggestion.

Screenshot (if applicable)

image

image

How to test

You can view it in Storybook.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug. - No, all visual
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

Vinnl added 2 commits March 14, 2025 11:21
For more consistency with stories and tests elsewhere in our
codebase.
@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Mar 14, 2025
@Vinnl Vinnl requested review from codemist and flozia March 14, 2025 10:27
@Vinnl Vinnl self-assigned this Mar 14, 2025
@Vinnl Vinnl requested a review from flodolo as a code owner March 14, 2025 10:27
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants