Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3969: Continue straight to /passwords-done #5698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Mar 11, 2025

References:

Jira: MNTOR-3969
Figma:

Description

We had a bug that, after completing the last leaked password in the guided flow, we'd shortly redirect you to the security recommendations page before showing the celebration screen.

How to test

  1. Navigate to the Monitor dashboard;
  2. Start the Guided experience to start fixing exposures manually;
    3.Go to the “Leaked passwords” section and fix all of them;
  3. Proceed through the celebration screen to the next section, the “Security recommendations” section;
  4. Observe the progress bar at the top of the screen, specifically the “Leaked passwords” counter there;
  5. Repeat until issue is triggered;

I also used this query to be able to go through the flow again after reproducing it. I'd also recommend to have just a few breaches, e.g. with the email address [email protected].

UPDATE subscribers SET breach_resolution = NULL WHERE primary_email = '[email protected]';

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug. - No, the router is mocked out, and it depends on how it deals with several .push calls.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

We had a bug that, after completing the last leaked password in the
guided flow, we'd shortly redirect you to the security
recommendations page before showing the celebration screen.
@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Mar 11, 2025
@Vinnl Vinnl requested review from codemist and flozia March 11, 2025 15:39
@Vinnl Vinnl self-assigned this Mar 11, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant