Bugfix FXIOS-12729 #27721 ⁃ Tab/Address bar autohide/autoreveal is incredibly annoying #28069
+33
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoanarios
commented
Jul 18, 2025
| @@ -15,6 +15,8 @@ final class TabScrollController: NSObject, | |||
| static let toolbarBaseAnimationDuration: CGFloat = 0.2 | |||
| static let minimalAddressBarAnimationDuration: CGFloat = 0.4 | |||
| static let heightOffset: CGFloat = 14 | |||
| static let minimumScrollThreshold: CGFloat = 20 | |||
| static let minimumScrollVelocity: CGFloat = 100 | |||
There was a problem hiding this comment.
we might need 2 values for velocity I feel that hiding the toolbar is not that bad but to show it again feels like I need to scroll faster
Client.app: Coverage: 35.28
Generated by 🚫 Danger Swift against ff00038 |
thatswinnie
approved these changes
Jul 21, 2025
|
|
||
| // If scrollview contenSize is bigger than scrollview height scroll is enabled | ||
| var hasScrollableContent: Bool { | ||
| return (UIScreen.main.bounds.size.height + 2 * UIConstants.ToolbarHeight) < |
There was a problem hiding this comment.
Is this working with stage manager as well? Shouldn't we use the window bounds instead of the screen bounds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
FXIOS-12729
Github issue
FXIOS-12559
Github issue
💡 Description
1- First added a threshold that takes into account velocity and translation to avoid toggling the toolbar from short interactions.
2- Update
hasScrollableContentto take into account the toolbar height to fix the bug where the toolbar was not hiding for short webpages (FXIOS-12559)🎥 Demos
It's hard to see the changes, but I added a video to show that small and slow scroll actions don't trigger a show/hide toolbar. I recommend testing to get a better feeling of the change
https://github.com/user-attachments/assets/38ff0fcb-4451-4d3d-9feb-c46d86d82acf
📝 Checklist
@Mergifyio backport release/v120)