Bugfix [Add new tab gesture] FXIOS issues on new Tab gesture #27993
Conversation
Client.app: Coverage: 35.26
Generated by 🚫 Danger Swift against e358495 |
FilippoZazzeroni
changed the title
|
@mergify backport release/v141 |
✅ Backports have been created
|
| case .topSites: | ||
| webPagePreview.setScreenshot(homepageScreenshot) | ||
| case nil, .blankPage: | ||
| // this is needed otherwise the compiler doesn't which setScreenshot overload to use |
There was a problem hiding this comment.
small typo in this comment - missing "know" after "doesn't"
| case nil, .blankPage: | ||
| // this is needed otherwise the compiler doesn't which setScreenshot overload to use | ||
| let url: URL? = nil | ||
| webPagePreview.setScreenshot(url) |
There was a problem hiding this comment.
Instead of passing a nil url, isn't it better to have a default parameter set to nil for setScreenshot function?
There was a problem hiding this comment.
yess i agree @PARAIPAN9
|
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏 |
* Added new tab page settings for the AddressbarPanGestureHandler * Fix new tab page * Add missing tests * Refactor code for better readability * Refactor as per code review --------- Co-authored-by: Filippo <[email protected]> (cherry picked from commit 0023ba8)
| let shouldLoadCustomHomePage = isToolbarRefactorEnabled && newTabSettings == .homePage | ||
| let homePageURL = NewTabHomePageAccessors.getHomePage(profile.prefs) |
There was a problem hiding this comment.
This PR looks to be causing the #28117 based on running git bisect.
This is the change that is causing the tests to fail. See more details in the comment on the backport. We should address this for v142, but don't need to backport fix for v141. Scheduled a meeting to chat with @FilippoZazzeroni on this.
📜 Tickets
Add new tab animation
Jira ticket
Fix blank tab when restarting the app
Jira ticket
Fix theme not being updated on add new tab
Jira ticket
Github issue
Add new tab sync with new tab settings
Jira ticket
Github issue
Add background shadow to Tab preview
Jira ticket
Github issue
💡 Description
Fix the issues reported on Add new tab feature and align new tab with the User settings around add new tab.
🎥 Demos
Simulator.Screen.Recording.-.iPhone.16.-.2025-07-16.at.11.18.20.mp4
📝 Checklist
@Mergifyio backport release/v120)