Bugfix [Add new tab gesture] FXIOS issues on new Tab gesture #27993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 35.26
Generated by 🚫 Danger Swift against e358495 |
FilippoZazzeroni
changed the title
|
@mergify backport release/v141 |
✅ Backports have been created
|
PARAIPAN9
reviewed
Jul 17, 2025
| case .topSites: | ||
| webPagePreview.setScreenshot(homepageScreenshot) | ||
| case nil, .blankPage: | ||
| // this is needed otherwise the compiler doesn't which setScreenshot overload to use |
There was a problem hiding this comment.
small typo in this comment - missing "know" after "doesn't"
| case nil, .blankPage: | ||
| // this is needed otherwise the compiler doesn't which setScreenshot overload to use | ||
| let url: URL? = nil | ||
| webPagePreview.setScreenshot(url) |
There was a problem hiding this comment.
Instead of passing a nil url, isn't it better to have a default parameter set to nil for setScreenshot function?
There was a problem hiding this comment.
yess i agree @PARAIPAN9
|
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏 |
Foxbolts
approved these changes
Jul 17, 2025
PARAIPAN9
approved these changes
Jul 21, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
* Added new tab page settings for the AddressbarPanGestureHandler * Fix new tab page * Add missing tests * Refactor code for better readability * Refactor as per code review --------- Co-authored-by: Filippo <[email protected]> (cherry picked from commit 0023ba8)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Add new tab animation
Jira ticket
Fix blank tab when restarting the app
Jira ticket
Fix theme not being updated on add new tab
Jira ticket
Github issue
Add new tab sync with new tab settings
Jira ticket
Github issue
Add background shadow to Tab preview
Jira ticket
Github issue
💡 Description
Fix the issues reported on Add new tab feature and align new tab with the User settings around add new tab.
🎥 Demos
Simulator.Screen.Recording.-.iPhone.16.-.2025-07-16.at.11.18.20.mp4
📝 Checklist
@Mergifyio backport release/v120)