Import fenix quarantine #834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozilla-pontoon
force-pushed
the
fenix_l10n_updates
branch
2 times, most recently
from
3a6f026
to
1b9c361
Compare
Delphine
requested changes
Nov 15, 2024
| @@ -235,8 +235,12 @@ | |||
| <string name="browser_menu_open_in_regular_tab">Open in regular tab</string> | |||
| <!-- Browser menu toggle that adds a shortcut to the site on the device home screen. --> | |||
| <string name="browser_menu_add_to_homescreen">Add to Home screen</string> | |||
| <!-- Browser menu toggle that adds a PWA of the site on the device home screen. --> | |||
| <string name="browser_menu_add_app_to_homescreen">Add app to Home screen</string> | |||
There was a problem hiding this comment.
@jonalmeida Seems like you introduced this string. Could you please spell out PWA so localizers know what this is referring to?
| <!-- Browser menu toggle that adds a shortcut to the site on the device home screen. --> | ||
| <string name="browser_menu_add_to_homescreen_2">Add to Home screen…</string> | ||
| <!-- Browser menu toggle that adds a PWA of the site on the device home screen. --> |
There was a problem hiding this comment.
@jonalmeida Please spell out PWA here as well
| <string name="browser_menu_tools_description_with_translate_2">Reader View, Translate,%s Print, Share, Open app</string> | ||
| <!-- Browser menu description that describes the various tools related menu items inside of the tools sub-menu | ||
| The first parameter is the label of the report site issue (for example: Report Site issue) --> | ||
| <string name="browser_menu_tools_description_2">Reader View,%s Print, Share, Open app</string> |
There was a problem hiding this comment.
@iorgamgabriel Seems like you landed this string. The parameter here seems off, could you please update?
mozilla-pontoon
force-pushed
the
fenix_l10n_updates
branch
from
1b9c361
to
e099812
Compare
Delphine
requested changes
Nov 15, 2024
| <string name="browser_menu_tools_description" moz:removedIn="133" tools:ignore="UnusedResources">Reader View, Print, Share, Open app</string> | ||
| <!-- Browser menu description that describes the various tools related menu items inside of the tools sub-menu | ||
| The first parameter is the label of the report site issue (for example: Report Site issue) --> | ||
| <string name="browser_menu_tools_description_with_translate_2">Reader View, Translate,%s Print, Share, Open app</string> |
There was a problem hiding this comment.
@iorgamgabriel Missed this one! The parameter here seems off, could you please update?
mozilla-pontoon
force-pushed
the
fenix_l10n_updates
branch
from
e099812
to
8b6f750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import fenix quarantine