Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clangd go-to-definition goes to include files #631

Open
linusheck opened this issue Nov 12, 2024 · 3 comments · May be fixed by #602
Open

clangd go-to-definition goes to include files #631

linusheck opened this issue Nov 12, 2024 · 3 comments · May be fixed by #602

Comments

@linusheck
Copy link
Contributor

If I start clangd on the automatically generated compile_commands.json and goto a definition, it will put me into

build/include/storm/solver/OptimizationDirection.h

instead of

src/storm/solver/OptimizationDirection.{h,cpp}

even though the include file is not mentioned in compile_commands.json. Sadly, we cannot find anyone else experiencing this issue anywhere on the internet.

@sjunges
Copy link
Contributor

sjunges commented Nov 12, 2024

I don't know whether #602 solves it, but it may.

@volkm
Copy link
Contributor

volkm commented Nov 13, 2024

I think the underlying issue is that we export all header files into build/include. I have similar issues when following the includes in e.g. CLion.
This might indeed be resolved after Sebastian's PR (...or not).

@sjunges
Copy link
Contributor

sjunges commented Nov 13, 2024

I actually don't want to do this export during builds anymore, but that is not yet part of the PR.

@sjunges sjunges linked a pull request Feb 19, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants