-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another update to Laravel-mongodb #153
base: master
Are you sure you want to change the base?
Conversation
Locally I also could not run the tests because I had to run
After updating the tests to use Monolog\Level instead of Monolog\Logger the tests run fine. Please take a look at it. |
I tried modifying the .scrutinizer.yml to add the mongodb extension. Looks like it is working. |
Please are you confident this PR branch can be used in a project now? @rmelet |
Hi ilejohn-official, I am going to try using it. The only things I changed are: the Update to laravel-mongodb 4.3, Using MongoDB\Laravel\Eloquent\Model instead of Jenssegers\Mongodb\Eloquent\Model, Using Monolog\Level instead of deprecated Monolog\Logger and one small change to make the tests run in the pull request. |
version 5 of mongodb laravel official package has been release and we need to upgrade to that version |
Description
With this update we can use the latest laravel-mongodb, a MongoDB based Eloquent model and Query builder for Laravel (Moloquent)
Motivation and context
Previously this was not an official mongodb package. The package from Jenssegers was renamed to mongodb/laravel-mongodb because of a transfer of ownership to MongoDB, Inc.
If it fixes open issues #143 and #148
How has this been tested?
Run all Unit Tests to a local mongodb
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!