Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set max_header_size not effect, not recycle a bad conn for http1 #2369

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alpha-baby
Copy link
Member

Issues associated with this PR

#2328 #2368

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (9935770) 60.70% compared to head (338d844) 60.71%.
Report is 5 commits behind head on master.

Files Patch % Lines
pkg/stream/http/stream.go 0.00% 14 Missing ⚠️
pkg/stream/http/connpool.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
+ Coverage   60.70%   60.71%   +0.01%     
==========================================
  Files         422      426       +4     
  Lines       37568    37734     +166     
==========================================
+ Hits        22804    22909     +105     
- Misses      12526    12576      +50     
- Partials     2238     2249      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spacewander
spacewander previously approved these changes Dec 24, 2023
Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants