Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove redundant condition predicate of logger level #2265

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] Remove redundant condition predicate of logger level #2265

wants to merge 2 commits into from

Conversation

LENSHOOD
Copy link

@LENSHOOD LENSHOOD commented Mar 24, 2023 •
edited

try to close #2264

Solutions

Maybe we could refactor the code as the following steps:

  • Step 1: batch replace all possible places
  • Step 2: check if some places should remain due to avoid pre-compute

@mosn-community-bot
Copy link

Hi @LENSHOOD, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@taoyuanyuan taoyuanyuan requested a review from 3062 March 24, 2023 05:42
@LENSHOOD LENSHOOD marked this pull request as ready for review March 27, 2023 08:12
@LENSHOOD LENSHOOD marked this pull request as draft March 27, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3062 3062 Awaiting requested review from 3062

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
cla:yes First-time contributor size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why do we always need to judge the log level before printing the log in business logic?
1 participant
@LENSHOOD