Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pingpong client中的上下文新建,避免和downstream的context混淆 #2232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fibbery
Copy link
Contributor

@fibbery fibbery commented Feb 10, 2023

Issues associated with this PR

Your PR should present related issues you want to solve.

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 60.32% // Head: 60.38% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (8e50ffb) compared to base (ea94051).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8e50ffb differs from pull request most recent head e8b5968. Consider uploading reports for the commit e8b5968 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
+ Coverage   60.32%   60.38%   +0.05%     
==========================================
  Files         422      422              
  Lines       37050    37051       +1     
==========================================
+ Hits        22351    22372      +21     
+ Misses      12477    12454      -23     
- Partials     2222     2225       +3     
Impacted Files Coverage Δ
pkg/stream/http/stream.go 35.23% <100.00%> (+0.13%) ⬆️
pkg/stream/xprotocol/connpool_pingpong.go 62.10% <100.00%> (+12.10%) ⬆️
pkg/upstream/healthcheck/healthchecker.go 88.65% <100.00%> (ø)
...ream/faulttolerance/regulator/default_regulator.go 81.81% <0.00%> (-18.19%) ⬇️
pkg/stream/stream.go 46.66% <0.00%> (-13.34%) ⬇️
pkg/upstream/servicediscovery/dubbod/bootstrap.go 64.58% <0.00%> (-4.17%) ⬇️
pkg/server/handler.go 40.50% <0.00%> (+0.17%) ⬆️
pkg/module/http2/transport.go 78.91% <0.00%> (+0.28%) ⬆️
pkg/module/http2/frame.go 84.47% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fibbery fibbery force-pushed the bugfix/fix_pingpong_client_ctx branch from 64420e6 to e8b5968 Compare February 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants