Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: jwtauthn #2208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

optimize: jwtauthn #2208

wants to merge 2 commits into from

Conversation

3062
Copy link
Contributor

@3062 3062 commented Dec 26, 2022

Issues associated with this PR

Your PR should present related issues you want to solve.

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

@3062 3062 changed the title refactor: jwtauthn optimize: jwtauthn Dec 26, 2022
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 60.35% // Head: 60.32% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (8f55762) compared to base (08a1b08).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
- Coverage   60.35%   60.32%   -0.04%     
==========================================
  Files         422      422              
  Lines       37048    37047       -1     
==========================================
- Hits        22362    22348      -14     
- Misses      12464    12471       +7     
- Partials     2222     2228       +6     
Impacted Files Coverage Δ
.../istio1106/filter/stream/jwtauthn/filter_config.go 68.18% <100.00%> (ø)
istio/istio1106/filter/stream/jwtauthn/matcher.go 89.79% <100.00%> (-0.21%) ⬇️
istio/istio1106/filter/stream/jwtauthn/verifier.go 90.12% <100.00%> (ø)
...aulttolerance/regulator/invocation_stat_factory.go 85.00% <0.00%> (-15.00%) ⬇️
pkg/upstream/servicediscovery/dubbod/bootstrap.go 64.58% <0.00%> (-4.17%) ⬇️
pkg/mtls/sds/subscriber.go 74.50% <0.00%> (-3.93%) ⬇️
pkg/stream/xprotocol/conn.go 40.43% <0.00%> (-1.10%) ⬇️
pkg/upstream/cluster/loadbalancer.go 73.80% <0.00%> (-0.80%) ⬇️
pkg/server/handler.go 39.78% <0.00%> (-0.72%) ⬇️
pkg/module/http2/transport.go 78.91% <0.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant