Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: get cgroup cpu core #137

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

perf: get cgroup cpu core #137

wants to merge 3 commits into from

Conversation

istudies
Copy link
Contributor

@istudies istudies commented Jan 8, 2023

  1. optimize getCGroupCPUCore() to return the number of CPU cores when the value cannot be obtained.
  2. optimize the use of WithCGroup() and WithGoProcAsCPUCore() together, and WithCGroup() has a higher priority.

@cch123 cch123 requested a review from doujiang24 January 9, 2023 08:13
Jun10ng
Jun10ng reviewed Jan 9, 2023
View reviewed changes
Jun10ng
Jun10ng reviewed Jan 10, 2023
View reviewed changes
Jun10ng
Jun10ng reviewed Jan 11, 2023
View reviewed changes
@Jun10ng
Copy link
Contributor

Jun10ng commented Jan 11, 2023

LGTM

@doujiang24

doujiang24
doujiang24 reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@istudies Nice work.

LGTM with a simple comment.
Also, thanks for explaining the meaning of -1 value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiang24 doujiang24 doujiang24 left review comments

@Jun10ng Jun10ng Jun10ng approved these changes

Assignees
No one assigned
Labels
cla:yes First-time contributor size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istudies @Jun10ng @doujiang24