-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix __repr__
method in abstract_site.Molecule
and abstract_site.Residue
#851
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 94.07% 94.07%
=======================================
Files 65 65
Lines 6953 6953
=======================================
Hits 6541 6541
Misses 412 412 ☔ View full report in Codecov by Sentry. |
__repr__
method in abstract_site.Molecule
__repr__
method in abstract_site.Molecule
and abstract_site.Residue
I'm not sure why all of these merge with upstream are showing up as commits here..I'll try and fix that after these recent PRs are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
When poking around some things while working on #850 I got a strange error when trying to look at a
Molecule
instance in a notebook. There is an error in the__repr__
method of both theMolecule
andResidue
classes inabstract_site.py
where it tries to call an attribute that doesn't exist.This PR fixes that, and adds some extremely simple tests that should have caught this.
Also, I added fields for Residue and Molecule to the
__repr__
method forSite
as I think it provides helpful info.