Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blank nvm_profile to skip modifications of shell config scripts #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huyz
Copy link

@huyz huyz commented Feb 13, 2024

For many folks, we already have shell config scripts that handle loading nvm and relevant shell completions.

These changes allow for skipping editing of the shell config, as also supported by nvm https://github.com/nvm-sh/nvm?tab=readme-ov-file#additional-notes

@morgangraphics
Copy link
Owner

If you already have a scripts that manage your NVM installation then what are you using this role for? Would you mind explaining your use case in more detail?

@huyz
Copy link
Author

huyz commented Feb 17, 2024

I don't have scripts to manage my NVM installation. I have my own way of enabling or disabling nvm, nodenv, pyenv, rbenv, sdkman, jenv, etc. inside my login scripts.

Imagine if I had all these enabled all the time? New shells would take forever to load.

To be honest I'm not sure what the point of automatically editing shell login scripts is. All of a sudden we treat coders as if they can't even edit and manage a few lines in their login scripts. This trend has never made sense to me.

@huyz
Copy link
Author

huyz commented Feb 17, 2024

Btw, another problem is that the login scripts are modified in such a way that symlinks are broken (lots of people point their login scripts to local git repo for example).

@morgangraphics
Copy link
Owner

Your personal opinions aside, I am trying to understand what you are attempting to accomplish here.

Do you want to choose your own shell?

Are you using this role to just install NVM and nothing else? Meaning you don't want the .xxxxrc file additions the NVM scripts add as part of the install?

@huyz
Copy link
Author

huyz commented Feb 18, 2024

Do you want to choose your own shell?

I'm not sure how to answer that question. I just don't want this role to care which shell I use as I can handle that part myself.

Are you using this role to just install NVM and nothing else? Meaning you don't want the .xxxxrc file additions the NVM scripts add as part of the install?

Yes just to install NVM and nothing else. I have several machines for which I have Ansible playbooks. Some of these tasks already propagate my login scripts that are "smart" in that they can already handle all my possible setup scenarios, while optimizing performance. So yes, I don't need any other roles to touch my login scripts (the .xxxxrc file additions)

@huyz
Copy link
Author

huyz commented Mar 31, 2024

I'm not sure I answered all your questions. Are you still wondering whether my use case is useful or common?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants