chore: make just recipes work on Windows - #1404
Open
tonyfettes wants to merge 2 commits into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonyfettes
force-pushed
the
codex/just-windows-support
branch
from
September 9, 2026 04:57
67f89f4 to
7567b4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows recipes currently depend on POSIX shell behavior and launchers, so normal
justcommands fail before reaching the underlying tools. This change runs all four justfiles with Windows PowerShell on Windows while preserving the default shell on macOS/Linux.absolute_path, preserve paths containing spaces, and omit an empty optional--browse-rootargument.npm.cmdon Windows.pythonon Windows for the existing Python lifecycle test, with aPYTHONoverride.test-cramand select Git for Windows' Bash explicitly, avoiding the WSL launcher on PATH. Keep the root test steps as ordered dependencies so overrides propagate.Windows validation
Executed real recipes using Windows PowerShell, just 1.37.0, the repository-pinned MoonBit v0.10.12+1634b282e in an isolated toolchain, the VS 2022 amd64 environment, Node 23.11.0, and Python 3.11.9.
Passed:
just build(native and JS),just editor-build,just cef-setup, andjust desktop-build-scripts-check.just test-cram: 24/24;just viz-test-browser: 13/13.just desktop-package: ZIP and installer generated after adding the installed NSIS directory to the process PATH. The installer was not run.moon info,moon fmt,moon fmt --check, andgit diff --check; no generated interface changes.The full Windows suite is not green:
just check: native--deny-warnrejects five unused fields/variables in bgjobs and worktree code.just testandjust test-moon: nativedeepseek/clientdiagnostics tests hung and were manually interrupted. Later root test stages were therefore exercised separately.just test-turn-finish: the run case passes; the serve process does not exit afteragent_finishedand is terminated by the 120-second test timer.just editor-test: JS 1875/1875; Wasm 1086/1090 and native 1220/1224, with the same four diagnostics-refresh failures; wasm-gc has no test entry.just editor-test-browser: 105/107; the component-only rerun is 68/70, reproducing the same read_api/viewer_api geometry failures.just desktop-test-browser: 56/57; the transcript Markdown local-file-link locator fails.These failures remain unresolved in this PR; they have not been compared against a separate base-branch run. Tests that self-skip for missing online credentials or
share not counted as coverage. Validation above is on Windows; macOS/Linux were not rerun.