lint: gate repo on moongrep and fix some-catch-none-unwrap call sites - #1348
Draft
tonyfettes wants to merge 3 commits into
Draft
lint: gate repo on moongrep and fix some-catch-none-unwrap call sites#1348tonyfettes wants to merge 3 commits into
tonyfettes wants to merge 3 commits into
Conversation
Flag the (Some(x) catch { _ => None }) is Some(y) antipattern, where a raising call is wrapped in Some only to be immediately unwrapped.
Rewrite the seven call sites matching the new rule to use try ... catch ... noraise, or a direct catch with an early return, so the success value is used directly instead of being wrapped only to be immediately unwrapped.
Run moonx moonbit-community/moongrep@0.1.18 -- scan --output-json and fail when it reports any finding, so the .moongrep/rules files become a CI-enforced lint contract.
tonyfettes
marked this pull request as ready for review
September 7, 2026 09:26
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonyfettes
marked this pull request as draft
September 7, 2026 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a moongrep structural lint rule, wires it into CI, and fixes the seven existing call sites it flags.
What changed
.moongrep/rules/some-catch-none-unwrap.yaml): flags the(Some(x) catch { _ => None }) is Some(y)antipattern, where a raising call is wrapped inSomeonly to be immediately unwrapped.try ... catch ... noraise(for skip/continue flow) or a directcatchwith an early return (forguard ... else return Noneflow), so the success value is used directly..github/workflows/ci.yml): a new lightweightmoongrepjob runsmoonx moonbit-community/moongrep@0.1.18 -- scan --output-jsonand fails on any finding, making.moongrep/rulesa CI-enforced contract.Files touched
mcp/stdio/ndjson.mbtmcp/streamhttp/transport.mbtdesktop/internal/codex/transport.mbteditor/server/host/native_host.mbteditor/server/host/language_provider.mbtValidation
moon checkclean for the affected modules (root,editor/server,desktop).moon test mcp/stdio mcp/streamhttp: 9/9 pass.moon fmt --checkclean on all changed files.