Skip to content

feat(editor): add MoonIDE CodeLens to SeekMoon - #1257

Draft
bzy-debug wants to merge 2 commits into
mainfrom
codex/seekmoon-codelens
Draft

feat(editor): add MoonIDE CodeLens to SeekMoon#1257
bzy-debug wants to merge 2 commits into
mainfrom
codex/seekmoon-codelens

Conversation

@bzy-debug

@bzy-debug bzy-debug commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Opening a MoonBit source file in SeekMoon now shows Local and Outside reference CodeLens actions above declarations. Clicking an action opens References Peek, with Outside references resolved on demand.

  • Add the host-neutral Viewer provider, lazy resolution, rendering, and command forwarding, and connect the desktop Source Viewer through moonide.codelens to moon ide codelens <relative-path> --json.
  • Keep CodeLens out of Diff, Original, History, Markdown, and MBTI presentations. Fence stale replies by source identity, model version, and navigation state.
  • Validate source paths through LanguagePath; resolve Local targets physically inside the workspace and remap them to the lexical root. Accept only the two reference actions and discard malformed result entries.
  • Use explicit desktop JSON codecs, preserve UTF-8 decoding errors in failed CLI output, and cover provider behavior, protocol validation, and browser interactions.

Validation after rebasing onto main (96e6362e)

The two feature commits remain patch-equivalent after the rebase.

  • Passed: just build, just editor-test (4,176 tests across supported targets), moon test --target js (3,205 tests), and moon cram test tests/cram (24 cases).
  • Passed: moon info && moon fmt with no generated or formatting changes, and git diff --check.
  • Passed: just editor-test-browser (106/106, including all three CodeLens scenarios).
  • just check is blocked by 10 unused-package warnings in unchanged root packages on stable moonc v0.10.12+1634b282e.
  • just test stops after native tests: 3,171 passed and 58 failed in unchanged agent/tool_definition.mbt and agent_tool/mbtx tests. Multiple failures report target directory source exists and is not a directory; JS and cram were run separately and passed.
  • The previous PR head's two nightly editor CI jobs failed during dependency resolution because Rabbita 0.15.4 imports moonbitlang/core/strconv. The latest main Editor run also has failing nightly jobs; the workflow marks nightly as continue-on-error. Refreshed CI must be checked separately.

Earlier implementation validation included 24/24 desktop browser tests and packaged macOS Proton/CEF testing of Local/Outside Peek, cross-file previews, stale replies, and absence from diffs. Those desktop checks were not rerun for this patch-equivalent rebase.

CodeLens requires a toolchain with moon ide codelens. Older toolchains use the provider error path and show no lenses.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T10:42:13.836776Z 08f4961 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08f4961b37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/internal/protocol/desktop_replies.mbt Outdated
Comment thread desktop/internal/host/moonide_ops.mbt Outdated
@bzy-debug
bzy-debug marked this pull request as draft September 4, 2026 02:32
@bzy-debug
bzy-debug force-pushed the codex/seekmoon-codelens branch 2 times, most recently from c699039 to cdeec08 Compare September 8, 2026 02:56
@bzy-debug
bzy-debug force-pushed the codex/seekmoon-codelens branch from cdeec08 to c0ad80b Compare September 8, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant