Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 🚧: Allow treasury to spend foreign assets (conversion via XcmWeightTrader) #3206

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

pLabarta
Copy link
Contributor

@pLabarta pLabarta commented Mar 4, 2025

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@pLabarta pLabarta changed the title WIP 🚧Pablo/multi asset treasury/via weight trader WIP 🚧: Allow treasury to spend foreign assets (conversion via XcmWeightTrader) Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2432 KB (+12 KB) 🚨

Moonbeam runtime: 2408 KB (no changes) 🚨

Moonriver runtime: 2420 KB (+8 KB) 🚨

Compared to latest release (runtime-3501)

Moonbase runtime: 2432 KB (+480 KB compared to latest release) 🚨

Moonbeam runtime: 2408 KB (+468 KB compared to latest release) 🚨

Moonriver runtime: 2420 KB (+480 KB compared to latest release) 🚨

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Coverage Report

@@                               Coverage Diff                                @@
##           master   pablo/multi-asset-treasury/via-weight-trader      +/-   ##
================================================================================
- Coverage   74.51%                                         74.47%   -0.04%     
  Files         381                                            381              
+ Lines       96551                                          96646      +95     
================================================================================
+ Hits        71937                                          71972      +35     
+ Misses      24614                                          24674      +60     
Files Changed Coverage
/node/service/src/lib.rs 62.28% (+0.24%) 🔼
/pallets/xcm-weight-trader/src/lib.rs 85.32% (-3.57%) 🔽
/pallets/xcm-weight-trader/src/mock.rs 68.66% (-14.98%) 🔽
/runtime/moonbase/src/lib.rs 50.17% (-0.17%) 🔽
/runtime/moonbase/tests/xcm_mock/parachain.rs 58.56% (-2.51%) 🔽
/runtime/moonbeam/src/lib.rs 44.35% (-0.08%) 🔽
/runtime/moonbeam/tests/xcm_mock/parachain.rs 58.56% (-2.51%) 🔽
/runtime/moonriver/src/lib.rs 44.57% (-0.08%) 🔽
/runtime/moonriver/tests/xcm_mock/parachain.rs 59.25% (-2.54%) 🔽

Coverage generated Tue Mar 4 17:34:18 UTC 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant