-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP 🚧: Allow treasury to spend foreign assets (conversion via XcmWeightTrader) #3206
Draft
pLabarta
wants to merge
13
commits into
master
Choose a base branch
from
pablo/multi-asset-treasury/via-weight-trader
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchMoonbase runtime: 2432 KB (+12 KB) 🚨 Moonbeam runtime: 2408 KB (no changes) 🚨 Moonriver runtime: 2420 KB (+8 KB) 🚨 Compared to latest release (runtime-3501)Moonbase runtime: 2432 KB (+480 KB compared to latest release) 🚨 Moonbeam runtime: 2408 KB (+468 KB compared to latest release) 🚨 Moonriver runtime: 2420 KB (+480 KB compared to latest release) 🚨 |
Coverage Report@@ Coverage Diff @@
## master pablo/multi-asset-treasury/via-weight-trader +/- ##
================================================================================
- Coverage 74.51% 74.47% -0.04%
Files 381 381
+ Lines 96551 96646 +95
================================================================================
+ Hits 71937 71972 +35
+ Misses 24614 24674 +60
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?