Allow usage of full PoV size #3198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmauro
added
B5-clientnoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2396 KB (-4 KB) ✅ Moonriver runtime: 2396 KB (-16 KB) ✅ Compared to latest release (runtime-3501)Moonbase runtime: 2420 KB (+468 KB compared to latest release) 🚨 Moonbeam runtime: 2396 KB (+456 KB compared to latest release) Moonriver runtime: 2396 KB (+456 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master manuel/allow-usage-of-full-pov-size +/- ##
======================================================================
Coverage 74.57% 74.57% 0.00%
Files 381 381
Lines 96700 96700
======================================================================
Hits 72114 72114
Misses 24586 24586
|
manuelmauro
added
the
not-breaking
RomarQ
previously approved these changes
Feb 25, 2025
RomarQ
reviewed
Feb 26, 2025
RomarQ
reviewed
Feb 26, 2025
|
@RomarQ I stripped the PRs of the PoV testing and will track that with an issue. |
RomarQ
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Allow usage of full PoV size.
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?