Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge MVP #3188

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Bridge MVP #3188

wants to merge 16 commits into from

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Feb 6, 2025

What does it do?

TODO

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@RomarQ RomarQ self-assigned this Feb 6, 2025
@RomarQ RomarQ changed the title Bridge PoC Bridge MVP Feb 25, 2025
@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes labels Feb 25, 2025
@RomarQ RomarQ added the D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Moonriver Weight Difference Report

File Extrinsic Old New Change Percent

Moonbeam Weight Difference Report

File Extrinsic Old New Change Percent

Copy link
Contributor

github-actions bot commented Feb 26, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2416 KB (-4 KB) 🚨

Moonbeam runtime: 2476 KB (+68 KB) 🚨

Moonriver runtime: 2476 KB (+64 KB) 🚨

Compared to latest release (runtime-3501)

Moonbase runtime: 2416 KB (+464 KB compared to latest release) 🚨

Moonbeam runtime: 2476 KB (+536 KB compared to latest release) 🚨

Moonriver runtime: 2476 KB (+536 KB compared to latest release) 🚨

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Coverage Report

@@                 Coverage Diff                 @@
##           master   rq/bridge-setup      +/-   ##
===================================================
- Coverage   74.51%            74.38%   -0.13%     
+ Files         381               389       +8     
- Lines       96551             96402     -149     
===================================================
- Hits        71940             71704     -236     
+ Misses      24611             24698      +87     
Files Changed Coverage
/pallets/moonbeam-foreign-assets/src/evm.rs 74.02% (+10.85%) 🔼
/pallets/moonbeam-foreign-assets/src/lib.rs 73.90% (-5.20%) 🔽
/pallets/moonbeam-foreign-assets/src/mock.rs 85.48% (+3.37%) 🔼
/pallets/moonbeam-lazy-migrations/src/foreign_asset.rs 98.60% (+3.57%) 🔼
/pallets/moonbeam-lazy-migrations/src/mock.rs 67.86% (+19.14%) 🔼
/runtime/common/src/apis.rs 28.77% (-0.05%) 🔽
/runtime/common/src/impl_moonbeam_xcm_call_tracing.rs 31.25% (+3.59%) 🔼
/runtime/moonbase/src/lib.rs 50.77% (+0.43%) 🔼
/runtime/moonbase/src/runtime_params.rs 42.86% (+2.86%) 🔼
/runtime/moonbase/tests/integration_test.rs 99.42% (-0.01%) 🔽
/runtime/moonbeam/src/lib.rs 46.28% (+1.85%) 🔼
/runtime/moonbeam/src/runtime_params.rs 42.86% (+2.86%) 🔼
/runtime/moonriver/src/lib.rs 46.63% (+1.98%) 🔼
/runtime/moonriver/src/runtime_params.rs 42.86% (+2.86%) 🔼

Coverage generated Wed Feb 26 10:57:58 UTC 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant