Test 🧪: add gas/weight tests for Foreign Assets calls #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2404 KB (no changes) 🚨 Moonriver runtime: 2392 KB (no changes) ✅ Compared to latest release (runtime-3401)Moonbase runtime: 2420 KB (+388 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+392 KB compared to latest release) 🚨 Moonriver runtime: 2392 KB (+380 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/test/foreign-assets-tests +/- ##
==================================================================
Coverage 74.59% 74.59% 0.00%
Files 380 380
Lines 96029 96029
==================================================================
Hits 71632 71632
Misses 24397 24397
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds tests for checking weight and gas costs associated with creating and interacting with Foreign Assets. On the Substrate side it checks the weights for creation, freeze, unfreeze and changing the XCM location. On the EVM side it just checks gas costs associated with a simple transfer.
What important points should reviewers know?
The key aspect of these tests is checking that the costs are not over the block limits and seem reasonable. This comes after detecting an issue in the benchmarks for these calls that caused much higher weights than the actual used storage and compute time.
Is there something left for follow-up PRs?
This PR does not consider XCM tests for interacting with the new implementation of Foreign Assets. These should be added to #3104.
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?