feat: Adds new organization settings parameters #879
Conversation
cfn-resources/organization/Makefile
Outdated
|
|
||
| build: | ||
| cfn generate | ||
| env GOOS=$(goos) CGO_ENABLED=$(cgo) GOARCH=$(goarch) go build -ldflags="$(ldXflags)" -tags="$(tags)" -o bin/handler cmd/main.go | ||
| env GOOS=$(goos) CGO_ENABLED=$(cgo) GOARCH=$(goarch) go build -ldflags="$(ldXflags)" -tags="$(tags)" -o bin/bootstrap cmd/main.go |
There was a problem hiding this comment.
updating to work with new cfn cli go plugin versions as per aws-cloudformation/cloudformation-cli#1053 (comment)
Related PR #881
There was a problem hiding this comment.
undoing this change for now as this resulted in errors when trying to submit resource to private registry and manually creating a stack. This is being addressed in #881
| Config *Config | ||
| Atlas *mongodbatlas.Client | ||
| AtlasV2 *atlasSDK.APIClient | ||
| AtlasSDKLatest *adminLatest.APIClient |
There was a problem hiding this comment.
adding new version of SDK to avoid breaking changes
maastha
changed the title
| @@ -19,6 +19,7 @@ require ( | |||
| github.com/tidwall/pretty v1.2.1 | |||
| go.mongodb.org/atlas v0.36.0 | |||
| go.mongodb.org/atlas-sdk/v20231115002 v20231115002.1.0 | |||
There was a problem hiding this comment.
Can we remove this SDK version?
| go.mongodb.org/atlas-sdk/v20231115002 v20231115002.1.0 |
There was a problem hiding this comment.
Since the new SDK has breaking changes, for now we need to keep both versions
|
|
||
| return sdkV2, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we want to update the examples to add new fields?
There was a problem hiding this comment.
good point! will add
maastha
dismissed stale reviews from lantoli and andreaangiolillo
via
6061afc
Proposed changes
This PR adds support for new setting params in the organization resource:
PATCH Update Settings for One Organization - https://www.mongodb.com/docs/atlas/reference/api-resources-spec/v2/#tag/Organizations/operation/updateOrganizationSettings
This PR also adds a new version of the Atlas SDK client.
Jira ticket: https://jira.mongodb.org/browse/CLOUDP-221421
Link to any related issue(s):
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmtand formatted my codeworks in Atlas
Further comments