Skip to content

CLOUDP-291623: Add list command for ASP PrivateLink endpoints #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2025
Merged

CLOUDP-291623: Add list command for ASP PrivateLink endpoints #3655

merged 3 commits into from
Feb 19, 2025

Conversation

tcannon91
Copy link
Collaborator

@tcannon91 tcannon91 commented Feb 14, 2025 •
edited
Loading

Proposed changes

Add the ability for users to list all PrivateLink endpoints available to Atlas Stream Processing

Jira ticket: CLOUDP-291623

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

tcannon91
tcannon91 commented Feb 14, 2025
View reviewed changes
internal/cli/events/list_test.go
@@ -17,7 +17,6 @@
package events

import (
"strings"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here and in other non streams files were autofixed by the cli lint command... just drive bying them.

@tcannon91 tcannon91 marked this pull request as ready for review February 14, 2025 15:48
@tcannon91 tcannon91 requested review from a team as code owners February 14, 2025 15:48
@tcannon91 tcannon91 changed the title CLOUDP-291668: Add list command for ASP PrivateLink endpoints CLOUDP-291623: Add list command for ASP PrivateLink endpoints Feb 14, 2025
jasonrydberg
jasonrydberg previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@jasonrydberg jasonrydberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. LGTM regardless though

jvincent-mongodb
jvincent-mongodb previously approved these changes Feb 19, 2025
View reviewed changes
Copy link

@jvincent-mongodb jvincent-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasonrydberg
jasonrydberg approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@jasonrydberg jasonrydberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tcannon91 tcannon91 merged commit 8dc44f2 into mongodb:master Feb 19, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrydberg jasonrydberg jasonrydberg approved these changes

@jvincent-mongodb jvincent-mongodb jvincent-mongodb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcannon91 @jasonrydberg @jvincent-mongodb