Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: silence exit status errors in plugins #3652

Merged
merged 3 commits into from
Feb 14, 2025
Merged

fix: silence exit status errors in plugins #3652

merged 3 commits into from
Feb 14, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented Feb 14, 2025 •
edited
Loading

Proposed changes

Fixes exit status

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review February 14, 2025 12:37
@blva blva requested a review from a team as a code owner February 14, 2025 12:37
jeroenvervaeke
jeroenvervaeke approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@jeroenvervaeke jeroenvervaeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva enabled auto-merge (squash) February 14, 2025 13:00
@blva blva disabled auto-merge February 14, 2025 13:01
@apix-bot APIx Bot
Copy link
Contributor

apix-bot bot commented Feb 14, 2025

Coverage Report 📈

Branch Commit Coverage
master ad87d1c 37.7%
fix-exit-status e6ee505 37.7%
Difference 0%

@blva blva merged commit 77466b8 into master Feb 14, 2025
24 checks passed
@blva blva deleted the fix-exit-status branch February 14, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blva @jeroenvervaeke