Skip to content

CLOUDP-279533 Add support to load proxy settings from network settings #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Nov 19, 2024

Proposed changes

Add support to load proxy settings from network settings

Jira ticket: CLOUDP-279533

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

this PR gets proxy settings from env on all OSes but on Windows and macOS it goes an extra mile to get settings from os see https://github.com/rapid7/go-get-proxied?tab=readme-ov-file#configuration for more info

@fmenezes fmenezes marked this pull request as ready for review November 19, 2024 17:09
@fmenezes fmenezes requested a review from a team as a code owner November 19, 2024 17:09
@jeroenvervaeke
Copy link
Collaborator

Tested on:

  • MacOS: Sonoma 14.7.1, working
  • Ubuntu 22.04: was already working, but only when restarting the terminal after changing proxy settings (the default ubuntu terminal sets HTTP_PROXY and HTTPS_PROXY)

@fmenezes fmenezes enabled auto-merge (squash) November 19, 2024 17:47
@gssbzn
Copy link
Contributor

gssbzn commented Nov 20, 2024

Does it work with authenticated proxies? based on this issue seems like a no for at least mac rapid7/go-get-proxied#15

[IANAL] any concern on this issue rapid7/go-get-proxied#16

@gssbzn
Copy link
Contributor

gssbzn commented Nov 20, 2024

Tested on:

Any test on windows?

@gssbzn gssbzn disabled auto-merge November 20, 2024 08:59
@fmenezes
Copy link
Collaborator Author

Does it work with authenticated proxies? based on this issue seems like a no for at least mac rapid7/go-get-proxied#15

No it does not, tested locally

[IANAL] any concern on this issue rapid7/go-get-proxied#16

Legal might be best positioned to answer

@fmenezes
Copy link
Collaborator Author

Given the legal concerns plus the library chosen seems unmaintained, I'll close this ticket at the moment, if the presented issues get resolved I'd reconsider this change

@fmenezes fmenezes closed this Nov 20, 2024
@gssbzn gssbzn deleted the CLOUDP-279533 branch February 20, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants