Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Netty event loop resource leak on MongoClient close. #1646

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Netty event loop resource leak on MongoClient close. #1646

wants to merge 3 commits into from

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin requested review from a team and NathanQingyangXu and removed request for a team March 13, 2025 00:39
@vbabanin vbabanin self-assigned this Mar 13, 2025
@vbabanin vbabanin requested review from katcharov and removed request for NathanQingyangXu March 13, 2025 00:39
vbabanin
vbabanin commented Mar 13, 2025
View reviewed changes
driver-sync/src/main/com/mongodb/client/internal/MongoClientImpl.java
public MongoClientImpl(final Cluster cluster,
final MongoClientSettings settings,
final MongoDriverInformation mongoDriverInformation,
@Nullable final AutoCloseable externalResourceCloser) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change aligns with the implementation in MongoClientImpl for the reactive-streams driver, as detailed here: MongoClientImpl Code.

@vbabanin
Fix test.
94bdf7e 
JAVA-5812
@vbabanin vbabanin mentioned this pull request Mar 13, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcharov katcharov Awaiting requested review from katcharov

Assignees

@vbabanin vbabanin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vbabanin