Skip to content

GODRIVER-3801 Skip TestConvenientTransactions/slow_operation_in_callback_retries for sharded clusters.#2322

Merged
qingyang-hu merged 1 commit intomongodb:masterfrom
qingyang-hu:godriver3801
Feb 12, 2026
Merged

GODRIVER-3801 Skip TestConvenientTransactions/slow_operation_in_callback_retries for sharded clusters.#2322
qingyang-hu merged 1 commit intomongodb:masterfrom
qingyang-hu:godriver3801

Conversation

@qingyang-hu
Copy link
Contributor

GODRIVER-3801

Summary

Skip TestConvenientTransactions/slow_operation_in_callback_retries for sharded clusters.

Background & Motivation

@mongodb-drivers-pr-bot
Copy link
Contributor

🧪 Performance Results

Commit SHA: a8b195e

The following benchmark tests for version 698b6b8629daf40007cb47f1 had statistically significant changes (i.e., |z-score| > 1.96):

Benchmark Measurement % Change Patch Value Stable Region H-Score Z-Score
BenchmarkSingleFindOneByID total_time_seconds -11.5159 1.0165 Avg: 1.1488
Med: 1.1565
Stdev: 0.0467
0.8029 -2.8302
BenchmarkSingleFindOneByID total_mem_allocs -8.2906 1565895.0000 Avg: 1707453.7547
Med: 1716690.0000
Stdev: 70608.2848
0.7256 -2.0048
BenchmarkSingleRunCommand allocated_bytes_per_op -0.1080 12183.0000 Avg: 12196.1721
Med: 12196.0000
Stdev: 5.2565
0.7924 -2.5059

For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch.

@mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

@qingyang-hu qingyang-hu marked this pull request as ready for review February 10, 2026 19:06
Copilot AI review requested due to automatic review settings February 10, 2026 19:06
@qingyang-hu qingyang-hu requested a review from a team as a code owner February 10, 2026 19:06
@qingyang-hu qingyang-hu requested a review from tadjik1 February 10, 2026 19:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a conditional skip for the "slow operation in callback retries" test when running on sharded clusters. The skip is necessary to avoid test failures caused by SERVER-96344, as tracked in GODRIVER-3801.

Changes:

  • Added a sharded cluster check to skip the "slow operation in callback retries" test when running on sharded topologies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qingyang-hu qingyang-hu merged commit b6c50f9 into mongodb:master Feb 12, 2026
34 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants