CLOUDP-352308 Publish both non-minified and minified bundles for dev and prod environments #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nima-taheri-mongodb
force-pushed
the
cloudp-352308-publish-both-dev-prod
branch
from
4ac1d84 to
5aba0c7
Compare
Contributor
|
Size Change: +577 kB (+29.6%) 🚨 Total Size: 2.52 MB
ℹ️ View Unchanged
|
nima-taheri-mongodb
changed the title
Contributor
|
Coverage after merging cloudp-352308-publish-both-dev-prod into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
nima-taheri-mongodb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
CLOUDP-352308
📝 Summary
This PR updates the build process so we generate both non-minified and minified versions of our bundles. The default export in
package.jsonis now the non-minified bundle, with the minified version provided as a production-specific export.Details
tools/build/src/minify.ts, accessed vialg-build minify, to minify all non-minified JavaScript files located indist.buildscript produces non-minified outputs, while a newbuild:minifyscript invokes theminifytask across all sub-projects (except those under@lg-tools/*) to generate minified bundles.package.jsonexportsto default to the non-minified bundle, adding the minified bundle as a dedicated production export.lg-build tscscript to correctly forward all received arguments.Rationale
🧪 Checklist
pnpm changesetand included documentation of changes